Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| .option('--root-dir <rootDir>', 'Root directory to run development server from.', process.cwd()) | ||
| .action(async (opts) => { | ||
| try { | ||
| await execa('npm', ['run', 'dev'], { stdio: 'inherit', cwd: opts.rootDir }); |
There was a problem hiding this comment.
I think this command should look for the local next binary in node_modules to run. What do you think?
There was a problem hiding this comment.
If so, I assume we should also run the generate script before running dev?
There was a problem hiding this comment.
hmmm yeah
we probably want to abstract that generate script out at some point too 🤔
jordanarldt
left a comment
There was a problem hiding this comment.
Seems pretty straightforward. LGTM
What/Why?
This is just a wrapper for the
devcommand in thecore/package.json. Allows changing port and root directory.Independently of the framework chosen, it will just run
next devbehind the scenes.Testing
Locally it runs.
Not sure how to unit test this, any ideas? 🤔
Migration
N/A