fix(core): set secure value whenever we prefix cookie#2526
Merged
chanceaclark merged 1 commit intocanaryfrom Aug 18, 2025
Merged
fix(core): set secure value whenever we prefix cookie#2526chanceaclark merged 1 commit intocanaryfrom
chanceaclark merged 1 commit intocanaryfrom
Conversation
🦋 Changeset detectedLatest commit: 5d3cb0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
matthewvolk
approved these changes
Aug 18, 2025
This was referenced Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
The anonymous session cookie had
securealways set to true regardless if we were prefixing it or not. This change updates the cookie to setsecureto the same "value" if we prefix the cookie with__Secure-.Testing
secure: false:secure: true:Migration
Just rebase like normal or manually update the code.