feat: support target prop in Footer links#2568
Merged
hunterbecton merged 1 commit intointegrations/makeswiftfrom Sep 2, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 4145846 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
matthewvolk
approved these changes
Sep 2, 2025
Contributor
matthewvolk
left a comment
matthewvolk
left a comment
There was a problem hiding this comment.
Looks good, when target is undefined it will simply fall back to not opening a new tab.
jorgemoya
approved these changes
Sep 2, 2025
hunterbecton
force-pushed
the
hunter/eng-10346-open-in-new-tab-property-not-working-in-site-footer
branch
from
e066968 to
4145846
Compare
matthewvolk
approved these changes
Sep 2, 2025
Contributor
matthewvolk
left a comment
matthewvolk
left a comment
There was a problem hiding this comment.
Re-approving after added changeset 👍
hunterbecton
deleted the
hunter/eng-10346-open-in-new-tab-property-not-working-in-site-footer
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
targetinFooterlinksTesting
CleanShot.2025-09-02.at.11.33.06.mp4