Skip to content

feat(core): Add gift certificates to orders list and order details#2645

Merged
jordanarldt merged 1 commit intoalphafrom
feat/add-gift-certificate-order-details
Oct 28, 2025
Merged

feat(core): Add gift certificates to orders list and order details#2645
jordanarldt merged 1 commit intoalphafrom
feat/add-gift-certificate-order-details

Conversation

@jordanarldt
Copy link
Copy Markdown
Contributor

@jordanarldt jordanarldt commented Oct 22, 2025 •
edited
Loading

What/Why?

Add ability to see Gift Certificates in the order details of previous orders, and ensure that they are displayed in the orders list as well.

Testing

image image

Migration

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 22, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ef35c41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
catalyst-b2b Ready Ready Preview Comment Oct 27, 2025 10:08pm
catalyst-canary Ready Ready Preview Comment Oct 27, 2025 10:08pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
catalyst Ignored Ignored Oct 27, 2025 10:08pm

@jordanarldt jordanarldt force-pushed the feat/add-gift-certificate-cart branch from 097f919 to 12bec68 Compare October 22, 2025 21:16
@jordanarldt jordanarldt force-pushed the feat/add-gift-certificate-order-details branch from 0c82ef1 to 12bec68 Compare October 22, 2025 21:19
@jordanarldt jordanarldt reopened this Oct 22, 2025
@jordanarldt jordanarldt marked this pull request as ready for review October 22, 2025 21:19
@jordanarldt jordanarldt requested a review from a team October 22, 2025 21:19
@jordanarldt jordanarldt force-pushed the feat/add-gift-certificate-cart branch from 12bec68 to 4fb9766 Compare October 23, 2025 19:56
@jordanarldt jordanarldt changed the title feat: Add gift certificates to orders list and order details feat(core): Add gift certificates to orders list and order details Oct 23, 2025
@jordanarldt jordanarldt force-pushed the feat/add-gift-certificate-order-details branch from e1849af to 47b6fa1 Compare October 23, 2025 19:57
@jordanarldt jordanarldt force-pushed the feat/add-gift-certificate-cart branch from 4fb9766 to 17d318e Compare October 27, 2025 16:54
@jordanarldt jordanarldt force-pushed the feat/add-gift-certificate-order-details branch from 47b6fa1 to 8640e04 Compare October 27, 2025 16:55
jorgemoya
jorgemoya approved these changes Oct 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jorgemoya jorgemoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just wondering if we have ever shown digital cart line items in orders.

Comment thread core/data-transformers/orders-transformer.ts
};
});
}) ?? [],
lineItems: [...lineItems, ...giftCertificates].flat(),
Copy link
Copy Markdown
Contributor

@jorgemoya jorgemoya Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we ever show digitalLineItems? 🤔

Copy link
Copy Markdown
Contributor Author

@jordanarldt jordanarldt Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgemoya Nope! That's currently a Catalyst gap that we need to address as soon as we can. We never implemented digital items in the order details.

Copy link
Copy Markdown
Contributor

@jorgemoya jorgemoya Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely forgot, good to know we're keeping track!

@jordanarldt jordanarldt force-pushed the feat/add-gift-certificate-cart branch 2 times, most recently from 2ba29eb to 4c0ff29 Compare October 27, 2025 18:39
@jordanarldt jordanarldt force-pushed the feat/add-gift-certificate-order-details branch from 8640e04 to ba148ad Compare October 27, 2025 18:42
@jordanarldt jordanarldt force-pushed the feat/add-gift-certificate-cart branch from 4c0ff29 to 03509bd Compare October 27, 2025 22:03
Base automatically changed from feat/add-gift-certificate-cart to alpha October 27, 2025 22:06
@jordanarldt jordanarldt force-pushed the feat/add-gift-certificate-order-details branch from ba148ad to ef35c41 Compare October 27, 2025 22:06
@jordanarldt jordanarldt merged commit 6ce3036 into alpha Oct 28, 2025
11 checks passed
@jordanarldt jordanarldt deleted the feat/add-gift-certificate-order-details branch October 28, 2025 15:12
@jordanarldt jordanarldt mentioned this pull request Oct 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorgemoya jorgemoya jorgemoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jordanarldt @jorgemoya