fix(core): Update with-routes to account for trailing slash or capitalizations when redirecting

[jordanarldt]

What/Why?

Update the with-routes middleware to account for the TRAILING_SLASH env var, as well as capitalized letters in 301 Redirects.

There was a reported issue where when using TRAILING_SLASH=false in the Catalyst environment variables, redirect loops could occur if you had a redirect going from /example-path -> /example-path/, or capitalizations like /some-url -> /some-URL

Testing

Tested locally, confirmed fix works.

Regression test results before changes:

Regression test results after changes:

Before fix

Dynamic 301 Redirect from /infinite-redirect-test to a product with the URL /infinite-redirect-test/ while TRAILING_SLASH=false

Screen.Recording.2025-11-05.at.4.54.51.PM.mov

Manual 301 Redirect from /redirect-test to /redirect-TEST

Screen.Recording.2025-11-05.at.4.55.46.PM.mov

After fix

Dynamic 301 Redirect from /infinite-redirect-test to a product with the URL /infinite-redirect-test/ while TRAILING_SLASH=false

Screen.Recording.2025-11-05.at.4.59.30.PM.mov

Manual 301 Redirect from /redirect-test to /redirect-TEST

Screen.Recording.2025-11-05.at.5.00.23.PM.mov

Migration

Copy changes from with-routes.ts using this PR as a reference

[changeset-bot]

🦋 Changeset detected

Latest commit: caa45fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@bigcommerce/catalyst-core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
catalyst-b2b	Ready	Preview	Comment	Nov 6, 2025 9:13pm
catalyst-canary	Ready	Preview	Comment	Nov 6, 2025 9:13pm

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
catalyst	Ignored			Nov 6, 2025 9:13pm

[migueloller]

Can we please get some regression tests for this fix @jordanarldt?

[jordanarldt]

Can we please get some regression tests for this fix @jordanarldt?

@migueloller For sure. I'll get that added in the morning. We don't currently have any test fixtures for creating 301 redirects, so I'll need to create some test fixtures / api clients, and then add a new functional test suite. It may use up some of my capacity but we definitely should have some tests for this.

[migueloller]

Do we not have the basics set up for spinning up Catalyst via Playwright and navigating to some URLs and then checking the response status code? If not, then that's definitely worth investing into!

[migueloller]

Based on this existing test, it seems like we're already set up to test something like this.

https://github.com/bigcommerce/catalyst/blob/canary/core/tests/ui/e2e/not-found.spec.ts

[chanceaclark]

Pretty much LMAO I have no idea what I was going to write here 😅

[jordanarldt]

Based on this existing test, it seems like we're already set up to test something like this.

https://github.com/bigcommerce/catalyst/blob/canary/core/tests/ui/e2e/not-found.spec.ts

@migueloller The issue only replicates when you've created some specific 301 Redirects. In order to write a test for this, we need to be able to create the dynamic 301 redirects to a product via the test suites, which will require a fixture 👍

[migueloller]

Ah I see. If we don't want to have to create the specific redirects for the BigCommerce API we could use Playwright's Mock APIs to mock the GraphQL request to include the relevant redirects?

[migueloller]

I think a fixture would be ideal, by the way. But I wanted to provide an option in case that was prohibitively complicated.

[migueloller]

The tests are looking great! Thanks @jordanarldt 🙏🏻