feat(reviews): add reviews form enabling shoppers to submit reviews#2709
feat(reviews): add reviews form enabling shoppers to submit reviews#2709chanceaclark merged 8 commits intocanaryfrom
Conversation
🦋 Changeset detectedLatest commit: 37f031b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| paginationInfo={streamablePaginationInfo} | ||
| previousLabel={t('previous')} | ||
| productId={productId} | ||
| reviews={streamableReviews} | ||
| reviewsLabel={t('title')} | ||
| streamableImages={streamableImages} | ||
| streamableProduct={streamableProductName} | ||
| streamableUser={streamableUser} | ||
| /> | ||
| <Stream fallback={null} value={streamableReviewsData}> | ||
| {(product) => |
There was a problem hiding this comment.
Bug: Missing translation keys for the review form in French and German will cause broken or empty labels for non-English users.
Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
Users accessing the site in French or German will see the review form with missing or broken labels. The form labels will either display untranslated key strings (e.g., Form.button), display empty strings, or default fallback values. This will make the new review submission feature unusable for all non-English users.
💡 Suggested Fix
Update fr.json, de.json, and all other supported language translation files with the complete Product.Reviews.Form section and its required keys.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: core/app/[locale]/(default)/product/[slug]/_components/reviews.tsx#L154-L189
Potential issue: Users accessing the site in French or German will see the review form
with missing or broken labels. The form labels will either display untranslated key
strings (e.g., `Form.button`), display empty strings, or default fallback values. This
will make the new review submission feature unusable for all non-English users.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference_id: 2700275
…2709) * feat(reviews): add product review submission form to pdp * fix(reviews): remove unused eslint directives * fix(reviews): make rating radio group label required * fix(reviews): rename component to ReviewForm * refactor(reviews): make entire review form controlled * fix(reviews): reset form after successful submission * fix(reviews): simplify logic for obfuscating name --------- Co-authored-by: Matthew Volk <matt.volk@bigcommerce.com> Co-authored-by: Chancellor Clark <chancellor.clark@bigcommerce.com>
…2709) * feat(reviews): add product review submission form to pdp * fix(reviews): remove unused eslint directives * fix(reviews): make rating radio group label required * fix(reviews): rename component to ReviewForm * refactor(reviews): make entire review form controlled * fix(reviews): reset form after successful submission * fix(reviews): simplify logic for obfuscating name --------- Co-authored-by: Matthew Volk <matt.volk@bigcommerce.com> Co-authored-by: Chancellor Clark <chancellor.clark@bigcommerce.com>
3 participants
re-merge #2676