feat(reviews): minor product reviews ux improvements#2756
Merged
matthewvolk merged 1 commit intocanaryfrom Dec 12, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 5533caf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
|
@matthewvolk Overall looks really good! Few notes:
|
a6c485e to
f014a51
Compare
f014a51 to
db41e6b
Compare
Contributor
Author
|
@andrewreifman Thank you for the quick review! Just pushed up changes that address all your feedback 🙂 |
db41e6b to
c60240f
Compare
jorgemoya
approved these changes
Dec 12, 2025
c60240f to
5533caf
Compare
matthewvolk
commented
Dec 12, 2025
| value={typeof textControl.value === 'string' ? textControl.value : ''} | ||
| /> | ||
| <Input | ||
| disabled={isAuthorDisabled} |
Contributor
Author
There was a problem hiding this comment.
Forgot that disabled fields don't submit with native HTML forms 😅 This fixes that while still preventing modifications to the input.
Contributor
Author
There was a problem hiding this comment.
("this" being changing disabled → readOnly)
jamesqquick
pushed a commit
that referenced
this pull request
Feb 11, 2026
chanceaclark
pushed a commit
that referenced
this pull request
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This PR depends on #2754
What/Why?
Improves product reviews UX:
Testing
reviews-ux-improvements.mp4
Updated Spacing for Product Cards:
Before
After
Migration
For developers with customized forks, merge conflicts may occur in:
New file:
core/vibes/soul/sections/product-detail/rating-link.tsx- This is a new component, no conflicts expected.GraphQL query changes:
core/app/[locale]/(default)/product/[slug]/page-data.tsnumberOfReviewsfield toreviewSummaryquerynumberOfReviewsis included inreviewSummaryComponent interface changes:
ProductCardinterface: Added optionalnumberOfReviews?: numbertoProductinterfaceRatingcomponent: Added optionalnumberOfReviews?: numberandshowNumberOfReviews?: booleanpropsProductDetailcomponent: Added optionalnumberOfReviews?: numbertoProductDetailProductinterfaceData transformation updates: If you've customized product data transformations in:
core/app/[locale]/(default)/(faceted)/brand/[slug]/page.tsxcore/app/[locale]/(default)/(faceted)/category/[slug]/page.tsxcore/app/[locale]/(default)/(faceted)/search/page.tsxYou'll need to add
numberOfReviews: product.reviewSummary.numberOfReviewsto your product mapping.Product detail page:
core/app/[locale]/(default)/product/[slug]/page.tsxnumberOfReviewsto product data passed toProductDetailReviewscomponent with<div id="reviews">for scroll targetingid="reviews"and the rating usesRatingLinkinstead ofRatingStyling changes: Minor spacing adjustments in
ProductCardcomponent (changedmb-2tospace-y-0.5on container, removedmb-2from subtitle). If you've customized these styles, review spacing adjustments.Note: This pull request description was generated with the assistance of AI.