Skip to content

fix(core): allow optional text fields in dynamic form #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorgemoya merged 1 commit into from
Dec 15, 2025
+26 −0
Merged

fix(core): allow optional text fields in dynamic form #2782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .changeset/pink-zoos-attend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
"@bigcommerce/catalyst-core": patch
---

Add missing check for optional text field in `core/vibes/soul/form/dynamic-form/schema.ts`.

## Migration

Add `if (field.required !== true) fieldSchema = fieldSchema.optional();` to `text` case in `core/vibes/soul/form/dynamic-form/schema.ts`:

```typescript
case 'text':
fieldSchema = z.string();

if (field.pattern != null) {
fieldSchema = fieldSchema.regex(new RegExp(field.pattern), {
message: 'Invalid format.',
});
}

if (field.required !== true) fieldSchema = fieldSchema.optional();

break;
```
2 changes: 2 additions & 0 deletions core/vibes/soul/form/dynamic-form/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ function getFieldSchema(field: Field) {
});
}

if (field.required !== true) fieldSchema = fieldSchema.optional();

break;

case 'password':
Expand Down