feat(core): allow customer subscription to Newsletter#2784
Merged
Conversation
🦋 Changeset detectedLatest commit: 631cb47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
5a9bdae to
3dbf6ff
Compare
3dbf6ff to
af40fbf
Compare
af40fbf to
b7c4528
Compare
b7c4528 to
5e02654
Compare
5e02654 to
41daacf
Compare
41daacf to
49f88d7
Compare
49f88d7 to
43decbb
Compare
43decbb to
d3d5b75
Compare
d3d5b75 to
f07025a
Compare
chanceaclark
approved these changes
Dec 19, 2025
f07025a to
78534bd
Compare
78534bd to
631cb47
Compare
jamesqquick
pushed a commit
that referenced
this pull request
Feb 11, 2026
chanceaclark
pushed a commit
that referenced
this pull request
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Implement functional newsletter subscription feature with BigCommerce GraphQL API integration.
What Changed
subscribe.tswith a real BigCommerce GraphQL API call using theSubscribeToNewsletterMutation.InlineEmailFormto useform.errorsinstead of field-level errors for better error display.Testing
End to end tests and locally.
Kapture.2025-12-19.at.14.05.16.mp4
Migration
Replace the
subscribeaction incore/components/subscribe/_actions/subscribe.tswith the latest changes to include:submission.reply()Update
inline-email-formto fix issue of not showing server-side error messages from form actions.core/vibes/soul/primitives/inline-email-form/index.tsxFieldErrorcomponent:// Remove: const { errors = [] } = fields.email;This change ensures that server-side error messages returned from form actions (like
formErrorsfrom Conform'ssubmission.reply()) are now properly displayed to users.Add the following translation keys to your locale files (e.g.,
messages/en.json):{ "Components": { "Subscribe": { "title": "Sign up for our newsletter", "placeholder": "Enter your email", "description": "Stay up to date with the latest news and offers from our store.", "success": "You have been subscribed to our newsletter.", "Errors": { "subcriberAlreadyExists": "You are already subscribed to our newsletter.", "invalidEmail": "Please enter a valid email address.", "somethingWentWrong": "Something went wrong. Please try again later." } } } }