fix: clear pagination cursors when sort option changes#2811
Merged
chanceaclark merged 1 commit intocanaryfrom Jan 6, 2026
Merged
fix: clear pagination cursors when sort option changes#2811chanceaclark merged 1 commit intocanaryfrom
chanceaclark merged 1 commit intocanaryfrom
Conversation
🦋 Changeset detectedLatest commit: 837be7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
When the sort option is changed in the product filter, the before/after pagination query params are now removed. This prevents stale pagination cursors from being used with the new sort order, which could lead to incorrect results or empty pages. Changes: - Updated Sorting component to use useQueryStates instead of useQueryState - Now manages sort, before, and after params together - Clears before and after params when sort value changes
chanceaclark
force-pushed
the
claude/clear-filter-on-sort-Pd5t4
branch
from
58a29fe to
837be7c
Compare
matthewvolk
approved these changes
Jan 6, 2026
jorgemoya
approved these changes
Jan 6, 2026
jamesqquick
pushed a commit
that referenced
this pull request
Feb 11, 2026
When the sort option is changed in the product filter, the before/after pagination query params are now removed. This prevents stale pagination cursors from being used with the new sort order, which could lead to incorrect results or empty pages. Changes: - Updated Sorting component to use useQueryStates instead of useQueryState - Now manages sort, before, and after params together - Clears before and after params when sort value changes Co-authored-by: Claude <noreply@anthropic.com>
chanceaclark
added a commit
that referenced
this pull request
Apr 27, 2026
When the sort option is changed in the product filter, the before/after pagination query params are now removed. This prevents stale pagination cursors from being used with the new sort order, which could lead to incorrect results or empty pages. Changes: - Updated Sorting component to use useQueryStates instead of useQueryState - Now manages sort, before, and after params together - Clears before and after params when sort value changes Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
When the sort option is changed in the product filter, the before/after pagination query params are now removed. This prevents stale pagination cursors from being used with the new sort order, which could lead to incorrect results or empty pages.
Changes:
Testing
Screen.Recording.2026-01-06.at.14.21.21.mov
Migration
Change the import from
useQueryStatetouseQueryStates, update the state management toconst [params, setParams] = useQueryStates({ [paramName]: parseAsString.withDefault(defaultValue), before: parseAsString, after: parseAsString }, { shallow: false, history: 'push' }), change the optimistic state to useparams[paramName], and update theonValueChangehandler to callsetParams({ [paramName]: value, before: null, after: null })instead ofsetParam(value). If you haven't customized this file, simply pulling the changes will work without any additional action.