feat: pass in additional attributes for script tags#2816
Merged
chanceaclark merged 1 commit intocanaryfrom Jan 8, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 030f2d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jorgemoya
approved these changes
Jan 8, 2026
jamesqquick
pushed a commit
that referenced
this pull request
Feb 11, 2026
chanceaclark
added a commit
that referenced
this pull request
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
This PR enhances the
scripts-transformer.tsto properly handle HTML attributes from BigCommerce script tags beyond justsrcattributes.What Changed
extractAttributes()function that parses and extracts all HTML attributes from script tags (e.g.,async,defer,data-*,crossorigin)extractScriptInfo()to preserve additional attributes when transforming scriptsWhy This Matters
Previously, the transformer only extracted
srcand inline content from BigCommerce script tags, losing important attributes likeasync,defer, or custom data attributes. This caused scripts to lose their intended loading behavior and metadata during transformation.Technical Details:
extractAttributes()function uses regex to parse the opening<script>tagasync,defer) and key-value attributes (e.g.,data-category="analytics")srcattribute is explicitly excluded since it's already handled separatelyTesting
Migration
Rebase the
scripts-transformer.tsfile.