fix(core): persist checkbox modifier in PDP#2817
Merged
Conversation
🦋 Changeset detectedLatest commit: 0a83e9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
10a13d9 to
d6764ac
Compare
jorgemoya
commented
Jan 8, 2026
Comment on lines
-336
to
-337
| // Ensure that if page is reached without a full reload, we are still setting the selection properly based on query params. | ||
| const fieldValue = value || params[field.name]; |
Contributor
Author
There was a problem hiding this comment.
Verified this is no longer needed.
chanceaclark
approved these changes
Jan 8, 2026
Contributor
chanceaclark
left a comment
There was a problem hiding this comment.
Love it when the changesets is more code than the actual changes ❤️
d6764ac to
074da7c
Compare
chanceaclark
approved these changes
Jan 9, 2026
878b66a to
0a83e9f
Compare
jamesqquick
pushed a commit
that referenced
this pull request
Feb 11, 2026
* fix(core): persist checkbox modifier in PDP * fix: handle default value for checkbox * fix: revert form changes but keep track of options in params * fix: update changset
chanceaclark
pushed a commit
that referenced
this pull request
Apr 27, 2026
* fix(core): persist checkbox modifier in PDP * fix: handle default value for checkbox * fix: revert form changes but keep track of options in params * fix: update changset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Persist the checkbox product modifier since it can modify pricing and other product data. By persisting this and tracking in the url, this will trigger a product refetch when added or removed. Incidentally, now we manually control what fields are persisted, since
option.isVariantOptiondoesn't apply tocheckbox, additionally multi options modifiers that are not variant options can also modify price and other product data.Testing
Without insurance:

With insurance (insurance is $100 in this example):

Migration
Step 1
Update
product-options-transformer.tsto manually track persisted fields:Fields that persist and can affect product pricing when selected:
Step 2
Remove
isVariantOptionfrom GQL query since we no longer use it:Step 3
Update
product-detail-form.tsxto include separate handing of the checkbox field:Step 4
Update schema in
core/vibes/soul/sections/product-detail/schema.ts: