chore(catalyst): CATALYST-1297 Run E2E tests on PRs#2822
Merged
jordanarldt merged 3 commits intocanaryfrom Jan 23, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 885bddb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
c8b3c91 to
1734c76
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
dd40301 to
16d78ef
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
16d78ef to
b96c61a
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
b96c61a to
83ba600
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
83ba600 to
abd05fc
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
abd05fc to
08cb116
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
08cb116 to
bbe4811
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
bbe4811 to
31fbf0c
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
31fbf0c to
3127077
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
3127077 to
2e09c1b
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
2e09c1b to
5efeb89
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
5efeb89 to
b3efeac
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
b3efeac to
8d31c4d
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
60dec77 to
954ae17
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
954ae17 to
f332816
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
f332816 to
848ef51
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
848ef51 to
c77b89f
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
c77b89f to
c694fd6
Compare
jordanarldt
changed the title
chanceaclark
approved these changes
Jan 21, 2026
Contributor
chanceaclark
left a comment
chanceaclark
left a comment
There was a problem hiding this comment.
Two 🍹's but looks good on my end.
Comment on lines
+115
to
+119
| - name: Build catalyst-client | ||
| run: pnpm --filter @bigcommerce/catalyst-client build | ||
|
|
||
| - name: Build catalyst-core | ||
| run: pnpm --filter @bigcommerce/catalyst-core build |
Contributor
There was a problem hiding this comment.
🍹 Could we just run pnpm build and let turbo cache the other projects? We'll need to provide the turbo env var here I think to enable the build cache, but allows us to not worry about each thing that needs to the built.
| - name: Run Tests | ||
| run: pnpm run test | ||
|
|
||
| e2e-tests: |
Contributor
There was a problem hiding this comment.
🍹 What about instead of defining each job manually, we use a matrix to run the tests. I threw AI to showcase what I mean on this branch (not sure it actually works though): CATALYST-1297...refactor/e2e-tests
Contributor
Author
There was a problem hiding this comment.
Looks promising! I'll try it.
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
de89294 to
83ebaba
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
83ebaba to
b2a9873
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
b2a9873 to
2fbef6d
Compare
jordanarldt
force-pushed
the
CATALYST-1297
branch
from
2fbef6d to
885bddb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Ensure Catalyst E2E tests are executed on pull requests. This will help prevent further breaking changes from contributions. There are 3 separate jobs:
E2E Functional Tests- Executes all e2e testsE2E Functional Tests (alternate locale)- Executes all tests that require an alternate locale to be usedE2E Functional Tests (TRAILING_SLASH=false)- Executes the functional tests that require theTRAILING_SLASHenv var to be disabled. This will prevent 301 redirect loop regressionsTesting
Test suites executed on this PR and they are passing.
Migration
Add
requiredprop to the Country selector and Country input fields incore/vibes/soul/sections/cart/shipping-form/index.tsxon lines 280 and 28For all other changes, use this PR as a reference.