Skip to content

fix: Fix successMessage translations#2831

Merged
chanceaclark merged 1 commit intocanaryfrom
fix-success-msg
Jan 26, 2026
Merged

fix: Fix successMessage translations#2831
chanceaclark merged 1 commit intocanaryfrom
fix-success-msg

Conversation

@funivan
Copy link
Copy Markdown
Contributor

@funivan funivan commented Jan 22, 2026

What/Why?

This PR fixes translation issues in French and Danish JSON files where CartItems (capital C) was used instead of cartItems (lowercase), and where <cartLink> incorrectly wrapped the entire message.

Root Cause

The code in core/app/[locale]/(default)/product/[slug]/_actions/add-to-cart.tsx (passes cartItems: quantity (lowercase) to the translation function. When translation files used CartItems (capital C), the pluralization failed because the variable name didn't match.

Additionally, the <cartLink> tag should only wrap the clickable text (like "your cart"), not the entire message including the plural variable.

Testing

image image
  • The cart link is clickable and navigates to /cart

Migration

None

@funivan funivan requested a review from a team January 22, 2026 10:16
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 22, 2026

⚠️ No Changeset found

Latest commit: 5bce7d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
catalyst Ready Ready Preview, Comment Jan 22, 2026 10:18am

Request Review

Copy link
Copy Markdown
Contributor

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @funivan!

@chanceaclark chanceaclark added this pull request to the merge queue Jan 26, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 26, 2026
@chanceaclark chanceaclark added this pull request to the merge queue Jan 26, 2026
Merged via the queue into canary with commit 588c53d Jan 26, 2026
9 checks passed
@chanceaclark chanceaclark deleted the fix-success-msg branch January 26, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants