Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Contributor
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
Contributor
Unlighthouse Performance Comparison — VercelComparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores. Summary ScoreAggregate score across all categories as reported by Unlighthouse.
Category Scores
Core Web Vitals
|
chanceaclark
approved these changes
Apr 23, 2026
jorgemoya
force-pushed
the
jorgemoya/ltrac-594-cli-tests-fail-on-windows-due-to-hardcoded-posix-path
branch
from
78e2118 to
6787b09
Compare
jorgemoya
changed the title
jorgemoya
changed the title
The spec files for the `build`, `dev`, and `start` CLI commands asserted that execa was called with `'node_modules/.bin/next'` (and `'.bigcommerce/wrangler.jsonc'` in the OpenNext case) using POSIX separators. Production code builds these paths via Node's `path.join`, which returns `\`-separated paths on Windows, so the assertions fail on `CLI Tests (windows-latest)`. Import `join` in each spec and build the expected path the same way the production code does, so the assertions match regardless of OS. Fixes LTRAC-594 Co-Authored-By: Claude <noreply@anthropic.com>
jorgemoya
force-pushed
the
jorgemoya/ltrac-594-cli-tests-fail-on-windows-due-to-hardcoded-posix-path
branch
from
6787b09 to
f23274e
Compare
jorgemoya
deleted the
jorgemoya/ltrac-594-cli-tests-fail-on-windows-due-to-hardcoded-posix-path
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: LTRAC-594
What/Why?
CLI Tests (windows-latest)started failing on theBasicworkflow. Four tests inpackages/catalyst/src/cli/commands/{build,dev,start}.spec.tsassert that execa is invoked with a specific path string, but they hardcoded POSIX separators (node_modules/.bin/next,.bigcommerce/wrangler.jsonc) while the production code builds those paths withpath.join, which returns\-separated paths on Windows.The ubuntu and macOS matrix legs still pass because their separator matches. This was latent until the GitHub
windows-latestrunner image rolled from20260405.77.1→20260413.84.1between 2026-04-14 (last green canary run) and 2026-04-23 (first red PR run) — same CLI source, different observed arg through the Vitest spy.Fix: build the expected path in the spec via
join(...)too, so the assertion mirrors production and matches whatever separator the current OS produces.Surfaced by PR #2989 (LTRAC-578). The failure was not caused by that PR.
Rollout/Rollback
@bigcommerce/catalyst(which is in the changesetignorelist), so no release is cut and no changeset is needed.Testing
pnpm --filter @bigcommerce/catalyst testlocally on macOS: all 44 tests pass, including the 4 previously Windows-only failing ones.CLI Testsmatrix legs (ubuntu / windows / macos) go green.Fixes LTRAC-594
Refs LTRAC-578