Skip to content

Upgrade lodash#122

Closed
mjschock wants to merge 1 commit intobigcommerce:masterfrom
mjschock:lodash_upgrade
Closed

Upgrade lodash#122
mjschock wants to merge 1 commit intobigcommerce:masterfrom
mjschock:lodash_upgrade

Conversation

@mjschock
Copy link
Copy Markdown
Contributor

@mjschock mjschock commented Aug 28, 2017

WHAT

  • this upgrades lodash to 4.x.

WHY

  • this prepares for the stencil-cli dep upgrade (STENCIL-3672 - Update dependencies stencil-cli#332) which includes a lodash upgrade. when stencil-cli with lodash 4.x pulls in paper with lodash 3.x, it uses lodash 4.x to run the paper lodash functions. i found this happens with npm 2.x anyway.

TESTING

  • i tried running stencil start with two versions of cli, one using lodash 4.x and the other 3.x. both scenarios produce a working store at localhost

@mcampa cc @bigcommerce/stencil-team

@mjschock mjschock closed this Dec 21, 2017
@mjschock mjschock deleted the lodash_upgrade branch December 21, 2017 18:54
@snyk-bot snyk-bot mentioned this pull request Sep 21, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 20, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Dec 20, 2021
Open
@jairo-bc jairo-bc mentioned this pull request Oct 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mjschock