STRF-4605: Add resourceHints helper#133
Merged
mattolson merged 1 commit intobigcommerce:2.xfrom May 9, 2018
mattolson:preconnect
Merged
STRF-4605: Add resourceHints helper#133mattolson merged 1 commit intobigcommerce:2.xfrom mattolson:preconnect
mattolson merged 1 commit intobigcommerce:2.xfrom
mattolson:preconnect
Conversation
tpietsch
reviewed
May 9, 2018
| _.each(fonts, function fontsIterator(font) { | ||
| var split = font.split('_'), | ||
| familyKey = split[1], // Eg: Open+Sans | ||
| weights = split[2]; // Eg: 400,700italic |
There was a problem hiding this comment.
is there another way than index? Regex would be safer + maybe a catch or something incase font doesnt have underscores
Contributor
Author
There was a problem hiding this comment.
This is existing code that I didn't spend time refactoring.
tpietsch
reviewed
May 9, 2018
tpietsch
left a comment
tpietsch
left a comment
There was a problem hiding this comment.
i would imagine there may be some public JS lib around font parsing or something.
* Extract font logic from getFontsCollection helper to make it reusable * Add resourceHints helper that generates a set of <link> tags for preconnect and dns-prefetch resource hints. This uses the font parsing logic from getFontsCollection helper to determine which font providers are used for the theme, and adds resource hints for expected hosts for these font providers. Also add one for the cdn host. * Add getFontLoaderConfig helper that generates a config suitable for use in Web Font Loader.
tpietsch
approved these changes
May 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resourceHintshelper that generates a set of tags forpreconnect and dns-prefetch resource hints. This uses the font parsing
logic from getFontsCollection helper to determine which font providers
are used for the theme, and adds resource hints for expected hosts
for these font providers. Also add one for the cdn host.
getFontLoaderConfighelper that generates a config suitable foruse in Web Font Loader.