Skip to content

build(make): silence nohup output in projppu checksums#117

Merged
github-actions[bot] merged 1 commit into
developfrom
fix/projppu-nohup-qend
Jun 25, 2026
Merged

build(make): silence nohup output in projppu checksums#117
github-actions[bot] merged 1 commit into
developfrom
fix/projppu-nohup-qend

Conversation

@traviswu-bigstack

Copy link
Copy Markdown
Contributor

What this PR does

The async checksum lines in make/projppu.mk used
nohup bash -c "…>file…" 2>&1 & — so nohup's own stdout was a tty and it printed
nohup: ignoring input … appending output to 'nohup.out' into the build log.

Redirect nohup's output with the $(QEND) macro (>/dev/null 2>&1 in normal builds,
empty under VERBOSE), matching the cgroups-v1 cleanup. The
nohup md5sum < IN > OUT 2>&1 lines are left as-is — they already send nohup's stdout
to the checksum file, and $(QEND) would clobber it.

Validation

Part of the cubecos build-output cleanup validated via remake jail + make pxe twice
(bigstack-oss/cubecos#1007): the nohup: message no longer appears in the build log.

Linked issue

Refs bigstack-oss/cubecos#1005 (cross-repo; the build-incrementality + output-cleanup tracking bug).

The async checksum lines used `nohup bash -c "...>file..." 2>&1 &`, so nohup's own
stdout was a tty and it printed `nohup: ignoring input / appending to nohup.out`
into the build log. Redirect nohup's output with the $(QEND) macro (>/dev/null 2>&1
in normal builds, empty under VERBOSE), matching the cgroups-v1 cleanup. The
`nohup md5sum < IN > OUT 2>&1` lines are left as-is — they already redirect nohup's
stdout to the checksum file, and $(QEND) would clobber it.

Refs bigstack-oss/cubecos#1005

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Travis Wu <travis.wu@bigstack.co>
@traviswu-bigstack traviswu-bigstack requested a review from a team as a code owner June 25, 2026 03:53
traviswu-bigstack added a commit to bigstack-oss/cubecos that referenced this pull request Jun 25, 2026
The api/ui/keycloak/appctl SOURCES rule listed $(RPMBUILD_DIR) as a normal
prerequisite, but the rule writes rpmbuild/SOURCES.tgz into that directory,
bumping its mtime on every build -> SOURCES is remade each run -> RPMS -> rpm ->
heavy_rootfs -> rootfs.cgz -> pkg -> initramfs/cgz, so a no-change rebuild redid
the whole tail. Make RPMBUILD_DIR an order-only prerequisite so its mtime no
longer triggers a rebuild.

Also in these files:
- write version/build_number with `>` not `>>` (>> doubled the file on a rebuild,
  e.g. v3.1.0v3.1.0, corrupting the rpm filename).
- ui/keycloak: touch $@ on SOURCES.
- drop tab-indented recipe comments that make echoes into the build output.

Bumps the hex submodule to the projppu nohup -> $(QEND) build-output cleanup
(bigstack-oss/hex#117). hex#117 must be reviewed and merged first.

Validated via remake jail + make pxe twice: pass 2 has no rpm/heavy_rootfs/cgz
rebuilds and no echoed comments.

Refs #1005

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Travis Wu <travis.wu@bigstack.co>
@Eandalf-Bigstack Eandalf-Bigstack added the done Merge the pull request label Jun 25, 2026
@github-actions github-actions Bot merged commit 32572f7 into develop Jun 25, 2026
5 checks passed
@github-actions github-actions Bot deleted the fix/projppu-nohup-qend branch June 25, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

done Merge the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants