fix: ensure indexBits matches mnemonic checksum capacity (#55)#61
Open
mvmax-dev wants to merge 1 commit into
Open
fix: ensure indexBits matches mnemonic checksum capacity (#55)#61mvmax-dev wants to merge 1 commit into
mvmax-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #55 where using
embeddedIndex: truewith 12-word mnemonics could lead to silent wallet loss.Changes:
indexBitsbased on the input mnemonic's entropy length (12-word = 4 bits, 24-word = 8 bits).This prevents x-coordinate truncation and collisions that cause recovery to fail or produce incorrect results.
Verified with 100 random split/combine trials on 12-word mnemonics.