impr: web search response #310
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,51 +1,137 @@ | ||
| import { | ||
| cleanClickableText, | ||
| extractTextFromReactNodeNormal, | ||
| extractTextFromReactNodeWeb, | ||
| parseClickableText, | ||
| transformLink, | ||
| } from '@/lib/clickable-results' | ||
| import { useThread } from '@/lib/hooks/use-thread' | ||
| import { cn } from '@/lib/utils' | ||
| import type { ClickableTextProps } from '@/types/types' | ||
| import React from 'react' | ||
|
|
||
| export function ClickableText({ | ||
| children, | ||
| isListItem, | ||
| sendMessageFromResponse, | ||
| webSearchResults = [], | ||
| onReferenceFound, | ||
| }: ClickableTextProps) { | ||
| const { webSearch } = useThread() | ||
|
|
||
| const extractedContent = webSearch | ||
| ? extractTextFromReactNodeWeb(children) | ||
| : extractTextFromReactNodeNormal(children) | ||
|
|
||
| const createClickHandler = (text: string) => () => { | ||
| if (sendMessageFromResponse && text.trim()) { | ||
| const cleanedText = cleanClickableText(text) | ||
| sendMessageFromResponse(`Tell me more about ${cleanedText}`) | ||
| } | ||
| } | ||
|
|
||
Bran18 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| const processLink = (linkElement: React.ReactElement) => { | ||
| const href = linkElement.props.href | ||
| // Buscar la referencia correspondiente | ||
| const reference = webSearchResults.find((result) => result.url === href) | ||
|
|
||
| if (reference && onReferenceFound) { | ||
| onReferenceFound(reference) | ||
| return null // Remover el link inline | ||
| } | ||
|
|
||
| return linkElement // Mantener links que no son de búsqueda web | ||
| } | ||
|
|
||
| const renderClickableContent = (clickableText: string, restText: string) => ( | ||
| <> | ||
| <button | ||
| className={cn('cursor-pointer hover:underline bg-transparent border-none p-0 m-0', isListItem ? 'text-blue-500' : 'text-link')} | ||
| onClick={createClickHandler(clickableText)} | ||
| type="button" | ||
| > | ||
| {clickableText} | ||
| </button> | ||
| {restText} | ||
| </> | ||
| ) | ||
|
|
||
| if (Array.isArray(extractedContent)) { | ||
| return extractedContent.map((content, index) => { | ||
| if (React.isValidElement(content)) { | ||
| if (content.type === 'a' && webSearch) { | ||
| return processLink(content) | ||
| } | ||
| // Manejo de elementos strong | ||
| if (content.type === 'strong') { | ||
| const strongContent = extractTextFromReactNodeNormal( | ||
| (content.props as { children: React.ReactNode }).children, | ||
| ) | ||
| const { clickableText, restText } = parseClickableText(strongContent + ':') | ||
|
|
||
| if (clickableText.trim()) { | ||
| return ( | ||
| <button | ||
| key={`clickable-${index}`} | ||
|
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion Replace array indices with stable unique keys. Using array indices as React keys can lead to rendering issues when items are reordered or removed. -key={`clickable-${index}`}
+key={`clickable-${clickableText}-${index}`}Also applies to: 119-119 🧰 Tools🪛 Biome (1.9.4)[error] 75-75: Avoid using the index of an array as key property in an element. This is the source of the key value. The order of the items may change, and this also affects performances and component state. (lint/suspicious/noArrayIndexKey) |
||
| className={cn( | ||
| 'cursor-pointer hover:underline', | ||
| isListItem ? 'text-blue-500' : 'text-link', | ||
| )} | ||
| onClick={createClickHandler(clickableText)} | ||
| type="button" | ||
| tabIndex={0} | ||
| > | ||
| {strongContent} | ||
| </button> | ||
| ) | ||
| } | ||
| return content | ||
| } | ||
|
|
||
| // Manejo de links cuando webSearch está activo | ||
| if (content.type === 'a' && webSearch) { | ||
| const parentContext = extractedContent | ||
| .filter( | ||
| (item) => | ||
| typeof item === 'string' || (React.isValidElement(item) && item.type === 'strong'), | ||
| ) | ||
| .map((item) => | ||
| typeof item === 'string' | ||
| ? item | ||
| : extractTextFromReactNodeNormal( | ||
| (item.props as { children: React.ReactNode }).children, | ||
| ), | ||
| ) | ||
| .join(' ') | ||
| return transformLink(content, parentContext) | ||
| } | ||
|
|
||
| return content | ||
| } | ||
|
|
||
| const { clickableText, restText } = parseClickableText(String(content)) | ||
|
|
||
| if (!clickableText.trim()) { | ||
| return content | ||
| } | ||
|
|
||
| return ( | ||
| <React.Fragment key={`clickable-${index}`}> | ||
| {renderClickableContent(clickableText, restText)} | ||
| </React.Fragment> | ||
| ) | ||
| }) | ||
| } | ||
|
|
||
| if (React.isValidElement(extractedContent)) { | ||
| return extractedContent | ||
| } | ||
|
|
||
| const { clickableText, restText } = parseClickableText(String(extractedContent)) | ||
|
|
||
| if (!clickableText.trim()) { | ||
| return <>{extractedContent}</> | ||
| } | ||
|
|
||
| return renderClickableContent(clickableText, restText) | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Consider throwing or logging the original error for better debugging
While returning a user-friendly message is good, completely swallowing the original error makes debugging harder. Consider logging the full error details or maintaining the throw with a wrapped error that includes both messages.