Fix uniq slug and id gen

[AndlerRL]

Summary by Sourcery

Refactor unique slug generation and thread ID handling to improve consistency and reliability in chat thread management

Bug Fixes:

• Fixed potential issues with slug generation by adding a maximum retry limit and fallback to random suffix
• Corrected thread ID usage by directly passing threadId instead of accessing through activeThread

Enhancements:

• Introduced a centralized function generateUniqueSlug() to handle unique slug generation with improved retry mechanism
• Simplified thread ID and slug handling across multiple functions

Chores:

• Removed unnecessary domain parameter in URL builder
• Added logging for thread ID debugging

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
masterbots	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 9, 2025 8:47pm

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request refactors slug generation to ensure uniqueness, fixes an issue with thread deletion, and adjusts chat parameters for continuation chats. The slug generation logic is now encapsulated in a single function, improving code maintainability. The thread deletion fix ensures that the correct thread is deleted. The changes to temperature and top_p improve the quality of continuation chats.

Sequence diagram for generating a unique slug

sequenceDiagram
  participant Client
  participant Server
  participant Database

  Client->>Server: generateUniqueSlug(baseContent)
  Server->>Server: toSlug(baseContent)
  Server->>Database: doesMessageSlugExist(finalSlug)
  Database-->>Server: slugCheck {exists: true, sequence: number}
  alt slugCheck.exists && attempt < maxAttempts
    Server->>Server: finalSlug = toSlug(`${baseContent} ${slugCheck.sequence + 1}`)
    Server->>Database: doesMessageSlugExist(finalSlug)
    Database-->>Server: slugCheck {exists: false, sequence: number}
  else slugCheck.exists
    Server->>Server: finalSlug = toSlug(`${baseContent.substring(0, 40)} ${nanoid(6)}`)
  end
  Database-->>Server: slugCheck {exists: false, sequence: number}
  Server-->>Client: finalSlug

Loading

File-Level Changes

Change	Details	Files
Refactors slug generation to use a single generateUniqueSlug function, improving code maintainability and readability.	Removes duplicated slug generation logic from the use-mb-chat hook. Introduces a generateUniqueSlug function in lib/url.ts to handle slug generation with retry logic and a random suffix if necessary. Updates the createThread function in use-mb-chat to use the new generateUniqueSlug function. Removes the throttled slug check function. Adds slug to the getThread query.	apps/masterbots.ai/lib/hooks/use-mb-chat.tsx apps/masterbots.ai/lib/url.ts apps/masterbots.ai/services/hasura/hasura.service.ts
Fixes an issue where the incorrect thread ID was being used when deleting threads.	Updates the deleteThread calls in use-mb-chat.tsx to use the threadId variable instead of activeThread?.threadId.	apps/masterbots.ai/lib/hooks/use-mb-chat.tsx
Adjusts the temperature and top_p parameters for continuation chats to make the output more deterministic.	Reduces the temperature and top_p values in the /api/chat/route.ts endpoint when handling continuation chats.	apps/masterbots.ai/app/api/chat/route.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sourcery-ai]

Hey @AndlerRL - I've reviewed your changes - here's some feedback:

Overall Comments:

• The changes look good, but it would be helpful to add a comment explaining why the threadId is being used directly instead of activeThread?.threadId in the deleteThread calls.
• Consider extracting the logic for adjusting temperature and top_p into a separate function for better readability.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (complexity): Consider extracting the retry logic into a helper function and applying the throttled check uniformly to reduce cognitive load and separate concerns, improving code maintainability and readability without altering functionality.

Consider extracting the retry logic into a helper function and applying the throttled check uniformly. This reduces cognitive load and separates concerns. For example:

async function tryUniqueSlug(
  baseContent: string,
  maxAttempts: number,
  checkFn: (slug: string) => Promise<{ exists: boolean; sequence: number }>
): Promise<string> {
  let attempt = 0;
  let finalSlug = toSlug(baseContent);
  let slugCheck = await checkFn(finalSlug);

  while (slugCheck.exists && attempt < maxAttempts) {
    attempt++;
    // Use a sequential suffix for readability
    finalSlug = toSlug(`${baseContent} ${slugCheck.sequence + 1}`);
    slugCheck = await checkFn(finalSlug);
  }

  // If still not unique, add a random suffix
  if (slugCheck.exists) {
    finalSlug = toSlug(`${baseContent.substring(0, 40)} ${nanoid(6)}`);
  }

  return finalSlug;
}

Then, update your generateUniqueSlug to use the helper with the throttled function:

export async function generateUniqueSlug(
  baseContent: string,
  maxAttempts = 10,
): Promise<string> {
  const throttledCheck = throttle(doesMessageSlugExist, 150);
  return tryUniqueSlug(baseContent, maxAttempts, throttledCheck);
}

This structure uniformly applies throttling and isolates the retry loop logic, making the code easier to follow and maintain without altering its functionality.

[AndlerRL]

@Bran18 I based this branch from yours and I am attempting to merge this into your branch. Mainly because some of your fixes are actually relevant with my fixes. So while you work on it (and we test) we can be pushing here and test the preview if needed.

cc - @merivercap

[Bran18]

@Bran18 I based this branch from yours and I am attempting to merge this into your branch. Mainly because some of your fixes are actually relevant with my fixes. So while you work on it (and we test) we can be pushing here and test the preview if needed.

cc - @merivercap

Sure sounds awesome! Nice idea