-
Notifications
You must be signed in to change notification settings - Fork 1
Fix: Dashboard category popup issues(web-pro) & Profile Page Bugs - October Release #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 19 commits
93f273a
240077a
1a2e27a
8f2eeaf
78e9fdf
130f8c9
92b2fb3
9907138
73e28c4
695cf24
5ec652b
e20ccd4
71cad84
84159bb
545111d
dc8ab41
a1f7610
aae157e
72505ba
05bc529
2bdf7fe
8c87593
8d1ba11
fd9935b
67e0dbc
1cffcab
314565e
ed70130
c226f24
d165690
c95b764
539adbd
7bf98bd
4fb555e
c5f79c6
a9345b3
8ba318e
3f36265
793c9b9
c1da516
c83000a
5854aa9
cc2cf93
4e979f6
25e6640
525fd5e
9f258c5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
AndlerRL marked this conversation as resolved.
Show resolved
Hide resolved
|
|
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,6 +54,11 @@ export function OnboardingSection({ isOpen, onClose }: OnboardingSectionProps) { | |
| setLocalSelectedCategories([]) | ||
| } | ||
|
|
||
| const handleSelectAll = () => { | ||
| const allCategoryIds = allCategories.map((category) => category.categoryId) | ||
| setLocalSelectedCategories(allCategoryIds) | ||
| } | ||
|
|
||
|
Comment on lines
+10
to
+63
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: cat -n apps/pro-web/components/shared/onboarding-section.tsxRepository: bitcashorg/masterbots Length of output: 9839 🏁 Script executed: rg "OnboardingSection" apps/pro-web --type tsx --type ts -B 2 -A 2Repository: bitcashorg/masterbots Length of output: 92 🏁 Script executed: rg "OnboardingSection" apps/pro-web -B 2 -A 2Repository: bitcashorg/masterbots Length of output: 1266 🏁 Script executed: rg "from.*onboarding-section" apps/pro-webRepository: bitcashorg/masterbots Length of output: 47 🏁 Script executed: rg "onboarding-section" apps/webRepository: bitcashorg/masterbots Length of output: 310 🏁 Script executed: rg "export.*onboarding-section\|from.*shared.*onboarding" apps/pro-webRepository: bitcashorg/masterbots Length of output: 47 🏁 Script executed: cat -n apps/web/components/shared/onboarding-section.tsx | head -100Repository: bitcashorg/masterbots Length of output: 3942 🏁 Script executed: rg "useCategorySelections" apps/pro-webRepository: bitcashorg/masterbots Length of output: 445 🏁 Script executed: grep -A 5 -B 5 "OnboardingSection" apps/web/components/routes/home/home-page.tsx | head -20Repository: bitcashorg/masterbots Length of output: 628 OnboardingSection UI renders but all selection logic is disabled, creating a broken modal if accidentally used The component has all core wiring commented out:
This means While currently unused in pro-web, exporting a non-functional UI component creates latent risk. If any future code imports and renders this component, it will trap the user with a broken modal. The web app version has full implementation (with proper state syncing, deduplication, and category management), showing this can work. Either guard this component behind a feature flag to prevent accidental use, or implement it fully by uncommenting the sidebar wiring, re-enabling the useEffect sync, and the categories grid mapping. 🤖 Prompt for AI Agents |
||
| if (!isOpen) return null | ||
|
|
||
| return ( | ||
|
|
@@ -99,6 +104,13 @@ export function OnboardingSection({ isOpen, onClose }: OnboardingSectionProps) { | |
| > | ||
| Clear All | ||
| </button> | ||
| <button | ||
| type="button" | ||
| onClick={handleSelectAll} | ||
| className="flex-1 px-3 py-2 text-sm font-medium text-white bg-gray-700 rounded-lg shadow-sm transition-colors sm:flex-none sm:px-4 hover:bg-gray-600" | ||
| > | ||
| Select All | ||
| </button> | ||
| <button | ||
| type="button" | ||
| onClick={handleApplySelection} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -89,6 +89,11 @@ export function CategoryDashboard({ | |
| setLocalSelectedCategories([]) | ||
| } | ||
|
|
||
| const handleSelectAll = () => { | ||
| const allCategoryIds = categories.map((category) => category.categoryId) | ||
| setLocalSelectedCategories(allCategoryIds) | ||
| } | ||
|
|
||
| if (!isOpen) return null | ||
|
|
||
| // Show loading state while category storage is loading | ||
|
|
@@ -165,6 +170,13 @@ export function CategoryDashboard({ | |
| > | ||
| Clear All | ||
| </button> | ||
| <button | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Didn't we add this before? I have been using the "Select All" from previous PRs merged to prod, unless is a duplicate? 🤔 |
||
| type="button" | ||
| onClick={handleSelectAll} | ||
| className="px-4 py-2 text-sm font-medium text-white bg-gray-700 rounded-lg shadow-sm transition-colors hover:bg-gray-600" | ||
| > | ||
| Select All | ||
| </button> | ||
| <button | ||
| type="button" | ||
| onClick={handleApplySelection} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you finished to debug, keep in mind to restore this 👀