Bugfix/workspace navigation v2 | Refactor metadata flow and simplify workspace logic #598
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| -- Could not auto-generate a down migration. | ||
| -- Please write an appropriate down migration for the SQL below: | ||
| -- alter table "public"."preference" add column "latest_organization" text | ||
| -- null; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,2 @@ | ||||||||||||
| alter table "public"."preference" add column "latest_organization" text | ||||||||||||
| null; | ||||||||||||
|
Comment on lines
+1
to
+2
Contributor
There was a problem hiding this comment. Add foreign key constraint to ensure referential integrity. The Apply this diff to add the constraint: alter table "public"."preference" add column "latest_organization" text
- null;
+ null constraint fk_preference_latest_organization
+ references "public"."organization"("name") on delete set null;Note: This assumes 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents🧩 Analysis chain🏁 Script executed: #!/bin/bash
# First, find all migration files to understand the schema
echo "=== Finding migration files ==="
find apps/hasura/migrations/masterbots -type f -name "*.sql" | head -20
echo -e "\n=== Checking organization table definition ==="
# Look for organization table creation
find apps/hasura/migrations/masterbots -type f -name "*.sql" -exec grep -l "create.*table.*organization" -i {} \;
echo -e "\n=== Searching for unique constraints on organization.name ==="
find apps/hasura/migrations/masterbots -type f -name "*.sql" -exec rg -l "unique.*name|unique.*constraint" {} \; | head -10Repository: bitcashorg/masterbots Length of output: 2602 🏁 Script executed: #!/bin/bash
# Search for references to organization in migration files
echo "=== Looking for foreign keys and references to organization ==="
find apps/hasura/migrations/masterbots -type f -name "*.sql" -exec rg -H "organization_id|references.*organization" {} \;
echo -e "\n=== Checking the preference table related migrations ==="
find apps/hasura/migrations/masterbots -type f -name "*preference*" | sortRepository: bitcashorg/masterbots Length of output: 1081 🏁 Script executed: #!/bin/bash
# Examine the migration file in question and surrounding files
echo "=== Migration file content ==="
cat apps/hasura/migrations/masterbots/1765857892283_alter_table_public_preference_add_column_latest_organization/up.sql
echo -e "\n=== Checking down migration ==="
cat apps/hasura/migrations/masterbots/1765857892283_alter_table_public_preference_add_column_latest_organization/down.sql 2>/dev/null || echo "No down migration found"
echo -e "\n=== Looking at preference table definition ==="
find apps/hasura/migrations/masterbots -type f -name "*preference*" | while read f; do echo "File: $f"; cat "$f"; echo "---"; doneRepository: bitcashorg/masterbots Length of output: 450 🏁 Script executed: #!/bin/bash
# Check for unique constraints on organization table specifically
echo "=== Organization table creation ==="
cat apps/hasura/migrations/masterbots/1761768880712_create_table_public_organization/up.sql
echo -e "\n=== Check for any constraints added to organization.name ==="
find apps/hasura/migrations/masterbots -type f -name "*.sql" -exec rg -H "organization.*name|alter.*organization" -A3 -B1 {} \;
echo -e "\n=== Search for all columns named 'organization' to see common patterns ==="
find apps/hasura/migrations/masterbots -type f -name "*.sql" -exec rg -H "\"organization\"" {} \; | head -30
echo -e "\n=== Check if latest_organization is used elsewhere ==="
rg -r "latest_organization" apps/hasura/migrations/masterbotsRepository: bitcashorg/masterbots Length of output: 3134 Use The Refactor to use an ID-based foreign key instead: alter table "public"."preference" add column "latest_organization_id" uuid
null constraint fk_preference_latest_organization
references "public"."organization"("organization_id") on delete set null;🤖 Prompt for AI Agents |
||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -722,7 +722,7 @@ export async function getUserWorkspaceInitialState( | |
| const activeDepartment = activeOrganization | ||
| ? (() => { | ||
| const deptName = departmentsByOrgArray[activeOrganization]?.[0] | ||
| if (!deptName) return null | ||
|
|
||
| // Get department ID from our chatbot-based mapping | ||
| const deptMap = departmentsByOrgFromChatbots[activeOrganization] | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Fragile relationship: references organization by name instead of ID.
This relationship maps
organization.name(text) topreference.latest_organization(text), which is fragile for the same reasons outlined in the migration review:If you refactor the migration to use
latest_organization_idinstead oflatest_organization, update this relationship accordingly:- name: organization_preference using: manual_configuration: column_mapping: - name: latest_organization + organization_id: latest_organization_id insertion_order: null remote_table: name: preference schema: public🤖 Prompt for AI Agents
🧩 Analysis chain
🏁 Script executed:
Repository: bitcashorg/masterbots
Length of output: 2115
🏁 Script executed:
Repository: bitcashorg/masterbots
Length of output: 1729
🏁 Script executed:
Repository: bitcashorg/masterbots
Length of output: 3958
🏁 Script executed:
Repository: bitcashorg/masterbots
Length of output: 47
🏁 Script executed:
rg -n "CREATE TABLE.*preference" --type sqlRepository: bitcashorg/masterbots
Length of output: 261
🏁 Script executed:
sed -n '61,120p' packages/mb-drizzle/src/drizzle/0000_pink_lionheart.sqlRepository: bitcashorg/masterbots
Length of output: 2011
🏁 Script executed:
cat -n apps/hasura/metadata/databases/masterbots/tables/public_organization.yaml | head -20Repository: bitcashorg/masterbots
Length of output: 672
🏁 Script executed:
rg -n "CREATE TABLE.*organization" --type sqlRepository: bitcashorg/masterbots
Length of output: 963
🏁 Script executed:
rg -n "latest_organization" --type sqlRepository: bitcashorg/masterbots
Length of output: 449
🏁 Script executed:
Repository: bitcashorg/masterbots
Length of output: 143
Change
organization_preferencefrom object_relationship to array_relationship.The
latest_organizationcolumn in the preference table has no unique constraint, allowing multiple preference records to share the same organization name. This creates a one-to-many relationship from organization to preferences, which must be modeled as anarray_relationshiprather thanobject_relationship. Anobject_relationshipwill only return the first matching preference, silently omitting others.Apply this change:
🤖 Prompt for AI Agents