-
Notifications
You must be signed in to change notification settings - Fork 1
chore: fix race conditions, hydration, build issues #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,7 +107,8 @@ export function ChatMessagePro({ | |
| <div className="flex-1 pr-1 space-y-2 overflow-hidden"> | ||
| <MemoizedReactMarkdown | ||
| className="min-w-full prose break-words dark:prose-invert prose-p:leading-relaxed prose-pre:p-0" | ||
| remarkPlugins={[remarkGfm, rehypeMathJax, remarkRehype]} | ||
| remarkPlugins={[remarkGfm]} | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to review for regressions—however, I have noticed issues with a few formulas and MathJax nor Rehype was picking them hence, I had to create a custom rule to support them, but that worked partially. We need to do a deep test with different formulas. This is important due there are plenty of startups that needs maths formulas to get things done. Maths are everywhere! |
||
| rehypePlugins={[rehypeMathJax]} | ||
| components={memoizedMarkdownComponents( | ||
| !(isBrowseView || isProfileView) | ||
| ? { | ||
|
|
@@ -117,7 +118,7 @@ export function ChatMessagePro({ | |
| : undefined, | ||
| )} | ||
| > | ||
| {cleanMessage.content} | ||
| {cleanMessage.content || ''} | ||
| </MemoizedReactMarkdown> | ||
|
|
||
| {actionRequired && ( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): The catch block logs an undefined
errorvariable instead of the caughterr.In this catch block,
erris the caught exception, butconsole.errorreferenceserror, which is undefined in this scope and will throw aReferenceError, masking the real issue. Useerrin the log call instead.