Peer details: connection type follow-ups by jonatack · Pull Request #180 · bitcoin-core/gui

jonatack · 2021-01-10T13:56:03Z

Three follow-ups to #163:

return relay type for inbound peers
improve markup handling in the tooltip to facilitate translations
update ConnectionType doxygen documentation

jonatack · 2021-01-10T17:08:25Z


-    QChar nonbreaking_hyphen(8209);
+    const QChar nonbreaking_hyphen(8209);
+    const std::vector<QString> CONNECTION_TYPE_DOC{


Named it CONNECTION_TYPE_DOC to show up in git grep with the constant of the same name in rpc/net.cpp and updated the net.h documentation

hebasto

Approach ACK 1a297a7.

hebasto

ACK e711200, tested on Linux Mint 20.1 (Qt 5.12.8):

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

jonatack · 2021-01-10T20:42:43Z

Thanks @hebasto! Updated.

git diff e711200 79a2576

diff --git a/src/qt/rpcconsole.cpp b/src/qt/rpcconsole.cpp
index 4fdc74c48..44addeeda 100644
--- a/src/qt/rpcconsole.cpp
+++ b/src/qt/rpcconsole.cpp
@@ -445,7 +445,7 @@ void RPCExecutor::request(const QString &command, const WalletModel* wallet_mode
     }
 }
 
-RPCConsole::RPCConsole(interfaces::Node& node, const PlatformStyle* _platformStyle, QWidget* parent) :
+RPCConsole::RPCConsole(interfaces::Node& node, const PlatformStyle *_platformStyle, QWidget *parent) :
     QWidget(parent),
     m_node(node),
     ui(new Ui::RPCConsole),
@@ -460,9 +460,9 @@ RPCConsole::RPCConsole(interfaces::Node& node, const PlatformStyle* _platformSty
 
     ui->splitter->restoreState(settings.value("PeersTabSplitterSizes").toByteArray());
 
-    const QChar nonbreaking_hyphen(8209);
+    constexpr QChar nonbreaking_hyphen(8209);
     const std::vector<QString> CONNECTION_TYPE_DOC{
-        tr("Inbound: initiated by peer"),
+        tr("Inbound Full/Block Relay: initiated by peer"),
         tr("Outbound Full Relay: default"),
         tr("Outbound Block Relay: does not relay transactions or addresses"),
         tr("Outbound Manual: added using RPC %1 or %2/%3 configuration options")

hebasto

re-ACK 79a2576, only suggested changes since my previous review.

promag

Concept ACK.

jarolrod

ACK 79a2576, tested on macOS 11.1 with Qt 5.15.2

RandyMcMillan · 2021-01-26T20:39:47Z

I don't believe this much information should be displayed in a mouse over event.
Attaching a click event to a UILabel (or a question mark image) would be a better approach (imo).
The click event could trigger a modal view that gives a more detailed explanation of
the information contained in the entire panel.

jonatack · 2021-01-26T20:49:13Z

This pull doesn't add the tooltip. It makes these follow-ups to #163:

return relay type for inbound peers
improve markup handling in the tooltip to facilitate translations
update ConnectionType doxygen documentation

(Feel free to open a pull to propose your approach.)

jonatack · 2021-01-26T20:50:27Z

This has 2 ACKs from @hebasto and @jarolrod and a Concept ACK from @promag. Anyone wish to ACK?

laanwj

Code review ACK 79a2576

jonatack · 2021-01-27T19:54:48Z

Thanks!

79a2576 doc: update ConnectionType Doxygen documentation (Jon Atack) f3153dc gui: improve markup handling of connection type tooltip (Jon Atack) 4f09615 gui: return inbound {full, block} relay type in peer details (Jon Atack) Pull request description: Three follow-ups to #163: - return relay type for inbound peers - improve markup handling in the tooltip to facilitate translations - update ConnectionType doxygen documentation ![Screenshot from 2021-01-11 08-37-44](https://user-images.githubusercontent.com/2415484/104156081-50e69300-53e0-11eb-9b0f-880cb5626d68.png) ACKs for top commit: hebasto: re-ACK 79a2576, only suggested changes since my [previous](bitcoin-core/gui#180 (review)) review. jarolrod: ACK 79a2576, tested on macOS 11.1 with Qt 5.15.2 laanwj: Code review ACK 79a2576 Tree-SHA512: 4a8d8f8bfbaefd68e8d1bf3b20d29e4a8e8cfe97b2f8d59d3a4c338a50b61de0a67d97bd8646c04bd5df5a9679c4954b9b46e7cba24bb89f4d0e44e94cf9d66c

jonatack mentioned this pull request Jan 10, 2021

Peer details: replace Direction with Connection Type #163

Merged

jonatack commented Jan 10, 2021

View reviewed changes

Comment thread src/qt/rpcconsole.cpp Outdated

hebasto reviewed Jan 10, 2021

View reviewed changes

Comment thread src/qt/rpcconsole.cpp Outdated

jonatack force-pushed the peer-details-connection-type-followups branch from 09f4414 to 3bb3ad2 Compare January 10, 2021 16:59

hebasto reviewed Jan 10, 2021

View reviewed changes

Comment thread src/qt/rpcconsole.cpp Outdated

jonatack commented Jan 10, 2021

View reviewed changes

jonatack force-pushed the peer-details-connection-type-followups branch 2 times, most recently from 4bb8c0c to 1a297a7 Compare January 10, 2021 17:34

hebasto requested changes Jan 10, 2021

View reviewed changes

Comment thread src/qt/guiutil.cpp Outdated

jonatack force-pushed the peer-details-connection-type-followups branch from 1a297a7 to e711200 Compare January 10, 2021 18:07

hebasto approved these changes Jan 10, 2021

View reviewed changes

Comment thread src/net.h

Comment thread src/qt/guiutil.cpp

Comment thread src/qt/rpcconsole.cpp Outdated

Comment thread src/qt/rpcconsole.cpp Outdated

jonatack and others added 3 commits January 10, 2021 21:33

gui: return inbound {full, block} relay type in peer details

4f09615

gui: improve markup handling of connection type tooltip

f3153dc

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

doc: update ConnectionType Doxygen documentation

79a2576

jonatack force-pushed the peer-details-connection-type-followups branch from e711200 to 79a2576 Compare January 10, 2021 20:40

hebasto approved these changes Jan 11, 2021

View reviewed changes

promag reviewed Jan 11, 2021

View reviewed changes

Comment thread src/qt/forms/debugwindow.ui

jarolrod reviewed Jan 15, 2021

View reviewed changes

laanwj approved these changes Jan 27, 2021

View reviewed changes

laanwj merged commit d1ddead into bitcoin-core:master Jan 27, 2021

jonatack deleted the peer-details-connection-type-followups branch January 27, 2021 19:54

This was referenced Jan 27, 2021

Save/restore RPCConsole geometry only for window #194

Merged

Handle peer addition/removal in a right way #164

Merged

Add peertablesortproxy module #18

Merged

maflcko reviewed Jan 28, 2021

View reviewed changes

Comment thread src/qt/guiutil.cpp

jonatack mentioned this pull request Jan 28, 2021

gui: ensure inbound block relay peers have relevant services #201

Closed

bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022

Uh oh!

Conversation

jonatack commented Jan 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonatack Jan 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonatack commented Jan 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

promag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jarolrod left a comment

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan commented Jan 26, 2021

Uh oh!

jonatack commented Jan 26, 2021

Uh oh!

jonatack commented Jan 26, 2021

Uh oh!

laanwj left a comment

Choose a reason for hiding this comment

Uh oh!

jonatack commented Jan 27, 2021

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jonatack commented Jan 10, 2021 •

edited

Loading

jonatack Jan 10, 2021 •

edited

Loading

jonatack commented Jan 10, 2021 •

edited

Loading