Make row color alternating in the Peers tab optional by hebasto · Pull Request #307 · bitcoin-core/gui

hebasto · 2021-05-01T14:20:59Z

This PR:

makes an "alternating row colors" feature in the Peers tab switchable to satisfy all users with different tastes.
is a follow up of Peertableview alternating row colors #298
is an alternative to Revert "Peertableview alternating row colors" #306

Screenshot:

hebasto · 2021-05-01T14:22:32Z

cc: @rebroad @jonatack @RandyMcMillan @Bosch-0 @jarolrod

jonatack

Concept ACK, thank you for adding this flexibility.

hebasto · 2021-05-01T15:50:39Z

Updated 8551215 -> fe7d615 (pr307.01 -> pr307.02, diff):

addressed @jonatack's comment

hebasto · 2021-05-01T15:52:37Z

Updated fe7d615 -> b7de85d (pr307.02 -> pr307.03, diff):

addressed @jonatack's comment

rebroad · 2021-05-01T22:35:41Z

I'm sorry for being picky..! Or a diva... or whatever it is...

Just to clarify, I think my preferences are, in order of preference-

No stripes by default, but a config option somewhere more hidden than this proposed option (maybe in a config file instead?)
Stripes by default, but a config option somewhere more hidden than this proposed option.
No stripes, no config option anywhere
Stripes, no config option anywhere
This proposed pull request.

hebasto · 2021-05-02T07:23:42Z

No stripes by default, but a config option somewhere more hidden than this proposed option (maybe in a config file instead?)

What is the rationale of hiding a visual appearance option from users?
The bitcoin.conf is not dedicated for such options.

promag · 2021-05-02T21:43:37Z

So far we had alternate rows and nobody complained AFAIK. If we add this option I think it should affect all tables, not only peers table.

Concept ACK figuring out the scope of appearance settings. Until then NACK, this particular option seems to have no grounds and might lead to similar pull requests.

jonatack · 2021-05-02T21:49:19Z

I think this is a fantastic first step back to a cleaner UI and it would be even better as a global option in a follow-up.

jarolrod · 2021-05-03T06:25:13Z

I agree with this

If we add this option I think it should affect all tables, not only peers table.

Also, this sets a good precedent for continuing to make the GUI user configurable.

RandyMcMillan · 2021-05-06T06:16:45Z

Concept ACK

hebasto · 2021-05-10T21:18:25Z

Rebased b7de85d -> 081842d (pr307.03 -> pr307.04) due to the conflict with #194.

jarolrod

ACK 081842d

Thanks for adding this option and tidying up the spacing in optionsdialog.ui

If we add this option I think it should affect all tables, not only peers table.

This can be addressed in a follow-up PR.

Start up GUI:

Start	Enable Option

Restart GUI:

Start: Setting Persists ✅	Disable Option

hebasto · 2021-06-05T10:49:00Z

Rebased 081842d -> 2bc53b6 (pr307.04 -> pr307.05) due to the conflict with #123.

hebasto · 2021-06-05T12:35:11Z

Rebased 2bc53b6 -> 3231689 (pr307.05 -> pr307.06) due to the conflict with #325.

jonatack

Tested ACK 3231689 modulo that it would be nice for the change to occur immediately when checking/unchecking the option and I would squash the last 2 commits.

Wishlist:

The options dialog opens to the last tab used
Further options for toggling alternate row coloring in other places (or globally)

hebasto · 2021-06-05T20:35:39Z

Rebased 3231689 -> 84be484 (pr307.06 -> pr307.07) due to the conflict with #256.

jarolrod

ACK 84be484

Tested on Arch Linux Qt 5.15.2, macOS 11.3 Qt 5.15.2, and cross-compile to Windows 10.

Notes on commits:

ada34cf
- Confirmed that the new indentation is correct
217d42b
- Code Review ACK, couple of nits (1, 2)
84be484
- Cherry-picking the first two commits then running clang-format-diff.py gives me the same diff

Screenshots:

Start	Enable

Restart	Disable

jarolrod · 2021-06-05T23:11:18Z

    <y>0</y>
-    <width>560</width>
-    <height>440</height>
+    <width>646</width>


Nit

there's not really a reason to change the size here. I guess this is a good place to answer a question:

"When adding new settings, should we maintain a certain level of padding between the last setting option and its enclosing box?"

Use PR Size Use Master Size

there's not really a reason to change the size here. I guess this is a good place to answer a question:

The reason is that successive openings and closings of the optionsdialog.ui in Qt Designer won't suggest size changes.

jarolrod · 2021-06-05T23:13:52Z

+        DatabaseCache,                // int
+        SpendZeroConfChange,          // bool
+        Listen,                       // bool
        OptionIDRowCount,


Nit in 217d42b

While here, you could document the type here is int.

Additionally, if you have to retouch, you could rename the commit from:
gui: Add "Alternating Row Color" settings for the Peers Tab

to:

qt: Add "Alternating Row Color" settings for the Peers Tab

While here, you could document the type here is int.

I don't think it is required to document the type of a counter, as it is not an option id.

Additionally, if you have to retouch, you could rename the commit from:
gui: Add "Alternating Row Color" settings for the Peers Tab

to:

qt: Add "Alternating Row Color" settings for the Peers Tab

Done in the recent push.

hebasto · 2021-06-11T06:49:17Z

Rebased 84be484 -> fdf8093 (pr307.07 -> pr307.08) due to the conflict with #4.

ghost · 2021-06-14T10:07:59Z

So far we had alternate rows and nobody complained AFAIK. If we add this option I think it should affect all tables, not only peers table.

Until then NACK, this particular option seems to have no grounds and might lead to similar pull requests.

Also NACK. First, alternate rows are added, then an option is added to disable it. Do not start option bloating because of groundless "tastes" of some users. Keep it simple (and unflexible).

jonatack · 2021-06-14T10:21:41Z

If we don't want to have options for accessibility then ISTM the striping should be removed globally.

Rspigler · 2021-06-15T18:20:02Z

Sad to see this closed. Concept ACK from me.

jonatack reviewed May 1, 2021

View reviewed changes

Comment thread src/qt/forms/optionsdialog.ui Outdated

hebasto force-pushed the 210501-stripes branch from 8551215 to fe7d615 Compare May 1, 2021 15:48

jonatack reviewed May 1, 2021

View reviewed changes

Comment thread src/qt/forms/optionsdialog.ui Outdated

hebasto force-pushed the 210501-stripes branch from fe7d615 to b7de85d Compare May 1, 2021 15:51

hebasto changed the title ~~Make row color alternating in the Peers Tab switchable~~ Make row color alternating in the Peers tab switchable May 1, 2021

hebasto changed the title ~~Make row color alternating in the Peers tab switchable~~ Make row color alternating in the Peers tab optional May 1, 2021

hebasto mentioned this pull request May 1, 2021

Revert "Peertableview alternating row colors" #306

Closed

hebasto added the UI All about "look and feel" label May 9, 2021

hebasto force-pushed the 210501-stripes branch from b7de85d to 081842d Compare May 10, 2021 21:16

jarolrod reviewed May 13, 2021

View reviewed changes

DrahtBot added the Needs rebase label Jun 1, 2021

hebasto force-pushed the 210501-stripes branch from 081842d to 2bc53b6 Compare June 5, 2021 10:47

DrahtBot removed the Needs rebase label Jun 5, 2021

hebasto force-pushed the 210501-stripes branch from 2bc53b6 to 3231689 Compare June 5, 2021 12:33

jonatack reviewed Jun 5, 2021

View reviewed changes

DrahtBot added the Needs rebase label Jun 5, 2021

hebasto force-pushed the 210501-stripes branch from 3231689 to 84be484 Compare June 5, 2021 20:33

DrahtBot removed the Needs rebase label Jun 5, 2021

jarolrod reviewed Jun 5, 2021

View reviewed changes

DrahtBot added the Needs rebase label Jun 9, 2021

hebasto added 3 commits June 11, 2021 09:43

qt, refactor: Fix indentation in optionsdialog.ui

b884c21

qt: Add "Alternating Row Color" settings for the Peers Tab

b124c2f

qt, refactor: Apply clang-format to the OptionsModel::OptionID enum

fdf8093

hebasto force-pushed the 210501-stripes branch from 84be484 to fdf8093 Compare June 11, 2021 06:47

DrahtBot removed the Needs rebase label Jun 11, 2021

hebasto closed this Jun 14, 2021

bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022

Uh oh!

Conversation

hebasto commented May 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented May 1, 2021

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hebasto commented May 1, 2021

Uh oh!

Uh oh!

hebasto commented May 1, 2021

Uh oh!

rebroad commented May 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented May 2, 2021

Uh oh!

promag commented May 2, 2021

Uh oh!

jonatack commented May 2, 2021

Uh oh!

jarolrod commented May 3, 2021

Uh oh!

RandyMcMillan commented May 6, 2021

Uh oh!

hebasto commented May 10, 2021

Uh oh!

jarolrod left a comment

Choose a reason for hiding this comment

Uh oh!

hebasto commented Jun 5, 2021

Uh oh!

hebasto commented Jun 5, 2021

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

hebasto commented Jun 5, 2021

Uh oh!

jarolrod left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jarolrod Jun 5, 2021

Choose a reason for hiding this comment

Uh oh!

hebasto Jun 6, 2021

Choose a reason for hiding this comment

Uh oh!

jarolrod Jun 5, 2021

Choose a reason for hiding this comment

Uh oh!

hebasto Jun 11, 2021

Choose a reason for hiding this comment

Uh oh!

hebasto Jun 11, 2021

Choose a reason for hiding this comment

Uh oh!

hebasto commented Jun 11, 2021

Uh oh!

ghost commented Jun 14, 2021

Uh oh!

jonatack commented Jun 14, 2021

Uh oh!

Rspigler commented Jun 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

hebasto commented May 1, 2021 •

edited

Loading

rebroad commented May 1, 2021 •

edited

Loading

jarolrod left a comment •

edited

Loading