wallet, refactor: Make WalletModel::sendCoins() return void#608
Merged
Conversation
Currently, the `WalletModel::sendCoins()` function always returns the same value. Also dead and noop code has been removed.
hebasto
changed the title
WalletModel::sendCoins() return voidWalletModel::sendCoins() return void
kristapsk
approved these changes
May 29, 2022
furszy
approved these changes
May 29, 2022
furszy
left a comment
furszy
left a comment
Member
There was a problem hiding this comment.
Code review ACK 1f653dc
Reviewing this found bitcoin/bitcoin#25239, so thanks for the push into the right direction hehe.
w0xlt
approved these changes
Jun 12, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 13, 2022
…Coins()` return `void` 1f653dc qt, wallet, refactor: Make `WalletModel::sendCoins()` return `void` (Hennadii Stepanov) Pull request description: Currently, the `WalletModel::sendCoins()` function always returns the same value. Also dead and noop (calling `processSendCoinsReturn(OK)`) code has been removed. The other `return` statements have been removed from the `WalletModel::sendCoins()` function in bitcoin#17154 and bitcoin#17165. ACKs for top commit: kristapsk: cr ACK 1f653dc furszy: Code review ACK 1f653dc shaavan: Code Review ACK 1f653dc w0xlt: Code Review ACK bitcoin-core/gui@1f653dc Tree-SHA512: 2b59495a7fc10b4de30fcc63fc3af92d50406e16031112eb72494736dce193ac1fbac0802623496cf81edcd16766e1647d9c4f3a607b3eb84cc50e273b999c04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
WalletModel::sendCoins()function always returns the same value.Also dead and noop (calling
processSendCoinsReturn(OK)) code has been removed.The other
returnstatements have been removed from theWalletModel::sendCoins()function in bitcoin/bitcoin#17154 and bitcoin/bitcoin#17165.