clang-tidy error (on not-linux): use nullptr instead of NULL

[pinheadmz]

Running clang-tidy on macos I get this error:

/Users/matthewzipkin/Desktop/work/bitcoin/src/ipc/libmultiprocess/src/mp/util.cpp:84:25: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
   84 |     pthread_threadid_np(NULL, &tid);
      |                         ^~~~
      |                         nullptr

I suspect the reason this hasn't triggered failures on our CI is that this code block is not compiled on linux:

libmultiprocess/src/mp/util.cpp

Lines 80 to 90 in 22bec91

	#ifdef __linux__
	buffer << syscall(SYS_gettid);
	#elif defined(HAVE_PTHREAD_THREADID_NP)
	uint64_t tid = 0;
	pthread_threadid_np(NULL, &tid);
	buffer << tid;
	#elif defined(HAVE_PTHREAD_GETTHREADID_NP)
	buffer << pthread_getthreadid_np();
	#else
	buffer << std::this_thread::get_id();
	#endif

[Sjors]

One does not simply ... run clang-tidy on macOS. Anything special needed to reproduce this?

[pinheadmz]

Simple!

brew install llvm:

--> which clang-tidy
/opt/homebrew/Cellar/llvm/22.1.1/bin/clang-tidy
--> clang-tidy --version
Homebrew LLVM version 22.1.1
  Optimized build.

Modified some code from bitcoin core ci/test/03_test_script.sh and added to .bash_profile:

bctidy(){
  cd /Users/matthewzipkin/Desktop/work/bitcoin
  cmake -B build_tidy -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
  cmake --build build_tidy -j 8

  set -eo pipefail
  (
    cd ./src/ &&
    if ! ( PYTHONUNBUFFERED=1  run-clang-tidy -p ../build_tidy -quiet -config-file=.clang-tidy -j 8 | tee  ../build_tidy/tidy-out.txt ); then
      echo
      echo "Failure generated from clang-tidy:"
      grep -C5 "error: " ../build_tidy/tidy-out.txt
    fi
  )
}

[Sjors]

Thanks, managed to reproduce. I also made a utility out of your script: https://github.com/Sjors/dev-utils/tree/master?tab=readme-ov-file#tidy-btc-maczsh

[Sjors]

Fixed in #262.

[fanquake]

Closed with #262?