BIP-32: fix RFC link - #885
Closed
Coding-Enthusiast wants to merge 1 commit into
Closed
Conversation
Member
luke-jr
added
the
Proposed BIP modification
Member
|
Unsure about this. RFC 2104 has no mention of HMAC-SHA512. So while it does specify it in abstract, I prefer referring to 4231 at least too to make sure it's pointing to something people can test against. |
Member
|
The author of the BIP has rejected this modification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC-4231 is the ASN.1 identifiers and test vectors for HMAC-SHA functions whereas RFC-2104 is the specification.