add more tests for leading zero - #905
Closed
klim0v wants to merge 2 commits into
Closed
Conversation
In the library https://github.com/btcsuite/btcutil and https://github.com/decred/dcrd all the tests that are listed here pass successfully, but there is an error on my case. Seed: "57fb1e450b8afb95c62afbcd49e4100d6790e0822b8905608679180ac34ca0bd45bf7ccc6c5f5218236d0eb93afc78bd117b9f02a6b7df258ea182dfaef5aad7", want pub: "xpub6CpsfWjghR6XdCB8yDq7jQRpRKEDP2LT3ZRUgURF9g5xevB7YoTpogkFRqq5nQtVSN8YCMZo2CD8u4zCaxRv85ctCWmzEi9gQ5DBhBFaTNo", want priv: "xprv9yqXG1Cns3YEQi6fsCJ7NGV5sHPiyZcbgLVst61dbLYyn7qy1G9aFtRmaYp481ounqnVf9Go2ymQ4gmxZLEwYSRhU868aDk4ZxzGvqJVH". The correction and discussion can be found here btcsuite/btcutil#161
Author
Member
|
This needs @sipa, not me |
luke-jr
added
the
Proposed BIP modification
Member
|
@klim0v Does btcutil not fail the existing test vector 3? If not, in what way does this one differ? If we're adding this, please make it a test vector 4 rather than squishing it into vector 3. |
Author
This was referenced Oct 19, 2020
Contributor
|
NACK |
Contributor
|
Is this resolved and can be closed, or is there still an issue that needs addressing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the library btcsuite/btcutil and decred/dcrd all the tests that are listed here pass successfully, but there is an error on my case.
The correction and discussion can be found here btcsuite/btcutil#161