Skip to content

fuzz: Limit max insertions in timedata fuzz test#21909

Merged
maflcko merged 1 commit into
bitcoin:masterfrom
maflcko:2105-fuzzMedian
May 11, 2021
Merged

fuzz: Limit max insertions in timedata fuzz test#21909
maflcko merged 1 commit into
bitcoin:masterfrom
maflcko:2105-fuzzMedian

Conversation

@maflcko

@maflcko maflcko commented May 11, 2021

Copy link
Copy Markdown
Member

It is debatable whether a size of the median filter other than 200 (the only size used in production) should be fuzzed. For now add a minimal patch to cap the max insertions. Otherwise the complexity is N^2 log(N), where N is the size of the fuzz input.

Hopefully fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34167

@maflcko
maflcko requested a review from practicalswift May 11, 2021 06:59
@DrahtBot DrahtBot added the Tests label May 11, 2021
@practicalswift

Copy link
Copy Markdown
Contributor

cr ACK fa95555: patch looks correct

@practicalswift

Copy link
Copy Markdown
Contributor

@MarcoFalke Don't forget to make the issues public before posting links to the OSS-Fuzz bug tracker, otherwise reviewers won't be able to view them :)

@maflcko
maflcko merged commit 88dc09d into bitcoin:master May 11, 2021
@maflcko
maflcko deleted the 2105-fuzzMedian branch May 11, 2021 18:47
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants