Skip to content

Update to bdk 0.17.0 - #73

Merged
notmandatory merged 10 commits into
bitcoindevkit:masterfrom
notmandatory:update_bdk0170
Apr 1, 2022
Merged

Update to bdk 0.17.0#73
notmandatory merged 10 commits into
bitcoindevkit:masterfrom
notmandatory:update_bdk0170

Conversation

@notmandatory

@notmandatory notmandatory commented Mar 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Fixes #81

Notes to the reviewers

Also added verify feature flag which enables transaction verification against consensus rules during sync.

I also had to disable the reserves tests and that feature will be broken until we can get it updated to use bdk 0.17 also. I created an issue https://github.com/weareseba/bdk-reserves/issues/4.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

@notmandatory notmandatory self-assigned this Mar 4, 2022
@notmandatory
notmandatory force-pushed the update_bdk0170 branch 2 times, most recently from 9a13c29 to 6766da9 Compare March 4, 2022 04:47
@rajarshimaitra rajarshimaitra linked an issue Mar 25, 2022 that may be closed by this pull request
Upgrade for bdk v0.17.0 #81
Closed
@rajarshimaitra

rajarshimaitra commented Mar 25, 2022

Copy link
Copy Markdown
Contributor

I just saw your PR after making the issue.. Looks like you are already on it.. I will review once its ready.. Lets get this one done first..

@rajarshimaitra

rajarshimaitra commented Mar 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@notmandatory let me know if you want me to take this on if you are busy in other parts.. I can try push it to finish line..

@notmandatory notmandatory added this to the Release 0.5.x milestone Mar 29, 2022
@notmandatory notmandatory changed the title [WIP] Update to bdk 0.17.0 Update to bdk 0.17.0 Mar 30, 2022
@notmandatory
notmandatory marked this pull request as ready for review March 30, 2022 00:23
@notmandatory

notmandatory commented Mar 30, 2022

Copy link
Copy Markdown
Member Author

Thanks Raj! it's ready to review now I'd appreciate your review.

@notmandatory
notmandatory marked this pull request as draft March 30, 2022 00:27
@notmandatory notmandatory mentioned this pull request Mar 30, 2022
Closed
@notmandatory
notmandatory marked this pull request as ready for review March 30, 2022 01:09
@notmandatory notmandatory mentioned this pull request Apr 1, 2022
Closed
rajarshimaitra
rajarshimaitra approved these changes Apr 1, 2022
View reviewed changes

@rajarshimaitra rajarshimaitra left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 14cbbd1

All changes looks good to me. This is ready to hit the party..

Below are few non blocking nits.. Nothing major, can be fixed later if needed..

Comment thread src/bdk_cli.rs Outdated
Comment thread src/bdk_cli.rs Outdated
Comment thread .github/workflows/cont_integration.yml
Comment thread src/lib.rs Outdated
@notmandatory
notmandatory merged commit 92d06d6 into bitcoindevkit:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rajarshimaitra rajarshimaitra rajarshimaitra approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@notmandatory notmandatory

Labels

None yet

Projects

BDK-CLI
Archived in project

Milestone

Release 0.5.0

Development

Successfully merging this pull request may close these issues.

Upgrade for bdk v0.17.0

2 participants

@notmandatory @rajarshimaitra