Skip to content

Add flush method to wallet - #115

Closed
thunderbiscuit wants to merge 1 commit into
bitcoindevkit:masterfrom
thunderbiscuit:fix/flush
Closed

Add flush method to wallet#115
thunderbiscuit wants to merge 1 commit into
bitcoindevkit:masterfrom
thunderbiscuit:fix/flush

Conversation

@thunderbiscuit

Copy link
Copy Markdown
Member

This PR cannot be merged before the flush() method is added to bdk (see upcoming PR)

This fixes #114. Took @notmandatory and I half a day to do it all, but we fully tested the new flush method and it did resolve the bug.

Note that at the moment the database() method on the wallet returns an immutable reference, hence why we cannot simply do:

fn flush(
    &self,
) -> Result<(), Error> {
    self.get_wallet().database().borrow().flush()
}

directly in bdk-ffi to trigger the flush.

@notmandatory

Copy link
Copy Markdown
Member

I think this one can be closed in favor of using sqlite db from #116.

@thunderbiscuit

Copy link
Copy Markdown
Member Author

Agreed.

@thunderbiscuit
thunderbiscuit deleted the fix/flush branch November 14, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Database is getting corrupted on Android

2 participants