Allow listing confirmed transactions - #18
Merged
Merged
Conversation
Contributor
Author
|
Do we want to return all transactions and filter out unconfirmed transactions in the consumer? |
Member
|
For this proof of concept demo I think it's ok to not filter and return what ever the |
notmandatory
pushed a commit
to notmandatory/bdk-ffi
that referenced
this pull request
Dec 12, 2021
…ransactions Allow listing confirmed transactions
thunderbiscuit
pushed a commit
to thunderbiscuit/bdk-ffi
that referenced
this pull request
Mar 1, 2022
…ransactions Allow listing confirmed transactions
thunderbiscuit
added a commit
to thunderbiscuit/bdk-ffi
that referenced
this pull request
Oct 26, 2022
Update library to new bdk-ffi API version 0.7.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8
Closes #2
We add an API to get confirmed transactions - we filter out unconfirmed transactions. We have a record to pass this information back to the API consumer. The demo application is updated to keep syncing until a confirmed transaction with the broadcasted id is available when listed.