Skip to content

feat: transactions use transactions_sort_by - #617

Merged
reez merged 1 commit into
bitcoindevkit:masterfrom
reez:sorted
Nov 14, 2024
Merged

feat: transactions use transactions_sort_by#617
reez merged 1 commit into
bitcoindevkit:masterfrom
reez:sorted

Conversation

@reez

@reez reez commented Nov 4, 2024

Copy link
Copy Markdown
Collaborator

Description

After discussing possible paths in #592 I believe the consensus was to just use transactions_sort_by under the hood in transactions because the example is likely what clients would expect out of the box.

Notes to the reviewers

I tested a local build of this in BDKSwiftExampleWallet to verify it worked as intended.

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez changed the title (draft) feat: transactions use transactions_sort_by feat: transactions use transactions_sort_by Nov 5, 2024
@reez

reez commented Nov 6, 2024

Copy link
Copy Markdown
Collaborator Author

Attempting to fix this failing CI on swift with #618

@reez
reez marked this pull request as ready for review November 6, 2024 03:59
@reez

reez commented Nov 6, 2024

Copy link
Copy Markdown
Collaborator Author

Attempting to fix this failing CI on swift with #618

#618 fixed the failing CI, so this is ready to go (I rebased as well)-

@reez
reez requested a review from thunderbiscuit November 6, 2024 16:31
@rustaceanrob

Copy link
Copy Markdown
Member

ACK 16a6bc8

@thunderbiscuit thunderbiscuit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 16a6bc8.

@reez

reez commented Nov 14, 2024

Copy link
Copy Markdown
Collaborator Author

rebased, will merge after tests pass

@reez
reez merged commit 7abbeb4 into bitcoindevkit:master Nov 14, 2024
@reez
reez deleted the sorted branch November 14, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants