Bump bdk version to 0.24.0 - #16
Merged
Merged
Conversation
Member
Author
|
This still has some bugs to fix and can't be merged until after bdk 0.24.0 is released. |
notmandatory
marked this pull request as draft
November 2, 2022 20:29
24 tasks
|
Looks like the only failing test is just the error message that slightly changed, this should be able to move forward |
Member
Author
|
I had to fix a couple things to get tests to pass:
|
notmandatory
force-pushed
the
update_bdk_024
branch
from
November 4, 2022 21:01
606fa3c to
b7ccd36
Compare
notmandatory
marked this pull request as ready for review
November 4, 2022 21:03
notmandatory
marked this pull request as draft
November 4, 2022 21:04
notmandatory
force-pushed
the
update_bdk_024
branch
from
November 6, 2022 01:06
b7ccd36 to
a944bb2
Compare
notmandatory
marked this pull request as ready for review
November 6, 2022 01:06
3 tasks
notmandatory
requested review from
ulrichard
and removed request for
rajarshimaitra
November 7, 2022 20:48
ulrichard
approved these changes
Nov 11, 2022
ulrichard
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. I also tested with our application, where this is used. All good. Thanks for maintaining this.
Member
Author
|
I'll make the release now and then we'll get the updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update BDK to the latest version, 0.24.0.
Notes to the reviewers
I also had to add base64 as a new dev dependency because it's not exported by bdk.