update to bdk v0.19.0 - #5
Merged
Merged
Conversation
This PR updates with the modifications needed for bdk v0.19.0 and rust-bitcoin v0.28.1.
6 tasks
9 tasks
Collaborator
|
Thanks for updating, before I even realized that 0.19 was released. |
Member
|
Also note that bdk has changed it's MSRV to 1.56.0, and current STABLE rust version to 1.60.0. |
Collaborator
|
Ah yes thanks for the heads up. |
1 task
Member
|
Thanks for pointing out the bad link in the README. This PR will fix it: bitcoindevkit/bdk#643 |
afilini
referenced
this pull request
in bitcoindevkit/bdk
Jun 28, 2022
d020ded Fix README.md link to rust 1.56.1 blog post (Steve Myers) Pull request description: ### Description Fix link to rust blog for 1.56.1 as pointed out by ulrichard: https://github.com/weareseba/bdk-reserves/pull/5#issuecomment-1159212838 ### Checklists #### All Submissions: * [x] I've signed all my commits Top commit has no ACKs. Tree-SHA512: a5bd76fca97dd64c12617b43230dbc36b1178e47224ce324b67cd13999e5f92d2a05d6a9e909841e6d5c6904f2fa426b6bee1001e757d53cc91fb4fd3803f56b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update for migration to
bdk v0.19.0andrust-bitcoin v0.28.Latest update in bdk has changed few internals and I have updated the tests and the code for them..
We need this crate to be at
bdk v0.19.0so we can move up the same inbdk-cli.Downstream PR dependent on this: bitcoindevkit/bdk-cli#92