Remove stale BitcoinDevKitTests target from Package.swift - #58
Open
ANAMASGARD wants to merge 1 commit into
Open
Conversation
Fixes bitcoindevkit/bdk-ffi#912 Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
Collaborator
|
Thanks, this looks good to me. I verified that the standalone Before merging this, I think I might want to make a companion source-of-truth update in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bitcoindevkit/bdk-ffi#912
What this does
Removes the stale
.testTarget(name: "BitcoinDevKitTests")entry fromPackage.swift.Why
The
Tests/folder was removed frombdk-swift, butPackage.swiftstill declared a test target pointing to it. This mismatch makes a fresh clone fail with:error: Source files for target BitcoinDevKitTests should be located under 'Tests/BitcoinDevKitTests', ...Now the manifest matches what's actually in the repo, so a fresh clone resolves and builds cleanly.
Scope
Package.swiftchanged (3 lines removed).bdk-ffi/bdk-swift(not needed, per the issue).Verification
swift package describesucceeds (no missing test-target error).swift build/swift testno longer fail on the stale test target path.Fixes bitcoindevkit/bdk-ffi#912
Ref: bitcoindevkit/bdk-ffi#912