Add Wallet::list_output method - #1190
Merged
Merged
Conversation
evanlinjin
marked this pull request as ready for review
November 1, 2023 20:26
notmandatory
approved these changes
Nov 1, 2023
notmandatory
left a comment
notmandatory
left a comment
Member
There was a problem hiding this comment.
ACK 63dea46
One small NIT is I'd label 723658f as a "refactor!" even though it's only a rename:
https://softwareengineering.stackexchange.com/questions/381736/renaming-%e2%8a%88-refactoring
38 tasks
evanlinjin
force-pushed
the
issue/1184
branch
2 times, most recently
from
November 6, 2023 03:26
2108c1d to
a84446f
Compare
Contributor
|
ACK a84446f |
evanlinjin
force-pushed
the
issue/1184
branch
2 times, most recently
from
November 14, 2023 22:34
356381b to
01037cd
Compare
54 tasks
evanlinjin
force-pushed
the
issue/1184
branch
from
November 20, 2023 20:37
01037cd to
3cfc823
Compare
evanlinjin
force-pushed
the
issue/1184
branch
from
November 20, 2023 20:38
3cfc823 to
6fb45d8
Compare
Inserted txouts will not be shown in `list_unspent` or `list_output`.
notmandatory
approved these changes
Nov 20, 2023
Member
There was a problem hiding this comment.
re-ACK 278210b
New docs do a good job of clarifying for users which outputs they'll get from list_output, and which they won't from insert_txout.
danielabrozzoni
approved these changes
Nov 21, 2023
danielabrozzoni
left a comment
danielabrozzoni
left a comment
Contributor
There was a problem hiding this comment.
ACK 278210b
Thanks for the docs update! Looking fantastic.
55 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1184
Description
Introduce
Wallet::list_outputmethod that lists all outputs (both spent and unspent) in a consistent history.Changelog notice
LocalUtxotoLocalOutput.Wallet::list_outputmethod.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: