Skip to content

fix(export): add tr descriptor - #1393

Merged
notmandatory merged 1 commit into
bitcoindevkit:masterfrom
rustaceanrob:tr-export
May 23, 2024
Merged

fix(export): add tr descriptor#1393
notmandatory merged 1 commit into
bitcoindevkit:masterfrom
rustaceanrob:tr-export

Conversation

@rustaceanrob

Copy link
Copy Markdown
Member

Description

Resolves #860 by adding export of taproot descriptors

Notes to the reviewers

Allows export as Core accepts taproot.

Changelog notice

  • Export taproot descriptors

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@ValuedMammal

Copy link
Copy Markdown
Contributor

Concept ACK

@storopoli storopoli left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK de51739

Simple change with an added test case.
Thanks!

@oleonardolima oleonardolima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK de51739 :shipit:

@oleonardolima

Copy link
Copy Markdown
Contributor

@notmandatory I think this one is missing the 1.0.0-alpha label, as it was on the #860, could you add to it, please ?

@notmandatory notmandatory modified the milestones: 1.0.0-beta, 1.0.0-alpha May 11, 2024

@notmandatory notmandatory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1b7c6df

@notmandatory
notmandatory merged commit a2d9401 into bitcoindevkit:master May 23, 2024
@rustaceanrob
rustaceanrob deleted the tr-export branch May 23, 2024 16:35
@notmandatory notmandatory mentioned this pull request May 23, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants