Remove crate-renaming - #1544
Merged
Merged
Conversation
evanlinjin
force-pushed
the
rm_serde_crate_rename
branch
from
August 9, 2024 06:06
17b6f9d to
f102b20
Compare
evanlinjin
force-pushed
the
rm_serde_crate_rename
branch
from
August 9, 2024 06:07
f102b20 to
318ce09
Compare
Collaborator
|
ACK 318ce09 |
LLFourn
approved these changes
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rust 1.60 introduces "namespaced features" so we can add a dependency without implicitly also defining a feature of the same name.
We can now get rid of crate-renaming and use "namespaced features" instead.
Thanks to @LLFourn for pointing this out.
Changelog notice
bdk_chainand use "namespaced features" instead.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing