feat(testenv): Add method new_with_config - #1545
Merged
evanlinjin merged 1 commit intoAug 12, 2024
Merged
Conversation
evanlinjin
reviewed
Aug 10, 2024
Contributor
Author
I tried turning it off, and running
gave this error |
This allows passing a custom config for either `BitcoinD` or `ElectrsD`. We also add a new `pub struct Config` for holding each of `bitcoind::Conf` and `electrsd::Conf`.
ValuedMammal
force-pushed
the
feat/testenv-config
branch
from
August 11, 2024 23:55
74aeb1a to
b3b6551
Compare
Contributor
|
ACK b3b6551 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this will be useful for passing a custom bitcoin config including e.g.
-blockfilterindexthat would not otherwise be included in the default config.Notes to the reviewers
Any other suggestions let me know @LagginTimes
Changelog notice
TestEnv::new_with_configfor passing custombitcoind::Conf,electrsd::Confconfig objectsChecklists
All Submissions:
cargo fmtandcargo clippybefore committing