Skip to content

chore(ci): pin proptest to 1.8.0 on 1.75.0 MSRV - #2075

Merged
oleonardolima merged 7 commits into
bitcoindevkit:release/chain-0.23.xfrom
oleonardolima:ci/pin-proptest-dep-to-supported-msrv
Nov 22, 2025
Merged

chore(ci): pin proptest to 1.8.0 on 1.75.0 MSRV#2075
oleonardolima merged 7 commits into
bitcoindevkit:release/chain-0.23.xfrom
oleonardolima:ci/pin-proptest-dep-to-supported-msrv

Conversation

@oleonardolima

@oleonardolima oleonardolima commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

Description

The proptest dependency is used in bdk_chain, it's already pinned to 1.2.0 on 1.63.0 MSRV, and wasn't a problem on the 1.75.0 MSRV. Recently, it also released a new version, bumping their MSRV, on proptest 1.9.0.

It adds a new step to pin it to 1.8.0 on the 1.75.0 MSRV CI step.

edit: I also had to update the pinned version webpki-roots@1.0.4 and socke2@0.6.1.

Notes to the reviewers

It only applies to release/chain-0.23.x branch; the master is already on 1.85.0 MSRV, which is not affected.

Changelog notice

### Changed
- deps: pin `proptest` to `1.8.0` on `1.75.0` MSRV
# all the pinned dependencies below affect only the `1.63.0` MSRV
- deps: pin `openssl` to `0.10.73`
- deps: pin `openssl-sys` to `0.9.109`
- deps: pin `syn` to `2.0.106`
- deps: pin `quote` to `1.0.41`
- deps: pin `socke2@0.6.1` instead of `0.6.0`
- deps: pin `webpki-roots@1.0.4` instead of `1.0.3`

Checklists

All Submissions:

@oleonardolima oleonardolima self-assigned this Nov 21, 2025
@oleonardolima oleonardolima added chore Non-coding related work github_actions Pull requests that update GitHub Actions code labels Nov 21, 2025
@oleonardolima

Copy link
Copy Markdown
Contributor Author

I wasn't expecting all these dependencies needing to be pinned for the 1.63.0 MSRV, but the openssl crate did a recent release that bumped their MSRV to 1.70.0, see: https://github.com/rust-openssl/rust-openssl/releases/tag/openssl-v0.10.74

Also, let me know if you think all squashed down to a single commit would be better, I just need this to move forward with #2027.

oleonardolima added a commit to oleonardolima/bdk that referenced this pull request Nov 21, 2025
chore(ci): pin `proptest` to `1.8.0` on `1.75.0` MSRV

chore(ci): pin `webpki-roots@1.0.4` instead of `1.0.3`

chore(ci): pin `socke2@0.6.1` instead of `0.6.0`

chore(ci): pin `quote` to `1.0.41`

chore(ci): pin `syn` to `2.0.106`

chore(ci): pin `openssl` to `0.10.73`

chore(ci): pin `openssl-sys` to `0.9.109`

@ValuedMammal ValuedMammal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 62ce876 No need to squash IMO.

@luisschwab luisschwab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 62ce876

@oleonardolima
oleonardolima merged commit 822ce5e into bitcoindevkit:release/chain-0.23.x Nov 22, 2025
19 checks passed
@oleonardolima
oleonardolima deleted the ci/pin-proptest-dep-to-supported-msrv branch November 22, 2025 04:37
@oleonardolima oleonardolima mentioned this pull request Mar 13, 2026
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Non-coding related work github_actions Pull requests that update GitHub Actions code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants