fix(esplora): deduplicate missing txids in fetch_txs_with_outpoints - #2104
Merged
oleonardolima merged 1 commit intoMar 20, 2026
Merged
Conversation
evanlinjin
requested changes
Jan 27, 2026
evanlinjin
left a comment
evanlinjin
left a comment
Member
There was a problem hiding this comment.
cACK
Looks good, thanks for fixing this.
Just a minor thing before merging - could you combine the two commits and include the scope?
I.e.
fix(esplora): deduplicate missing txids in fetch_txs_with_outpoints
phrwlk
force-pushed
the
fix/esplora-dedup-missing-txids-outpoints
branch
from
January 27, 2026 13:10
2c95146 to
0071ee6
Compare
phrwlk
changed the title
Contributor
Author
Did it |
evanlinjin
force-pushed
the
fix/esplora-dedup-missing-txids-outpoints
branch
from
January 28, 2026 04:48
0071ee6 to
787e07c
Compare
oleonardolima
self-requested a review
February 2, 2026 15:43
Collaborator
|
Can you update the PR description to follow the template, and also add the changelog changes in it ? |
Member
|
This will also need a rebase also since I merged #2123. |
34 tasks
oleonardolima
force-pushed
the
fix/esplora-dedup-missing-txids-outpoints
branch
from
March 19, 2026 22:14
787e07c to
3b6b3ba
Compare
oleonardolima
approved these changes
Mar 19, 2026
oleonardolima
left a comment
oleonardolima
left a comment
Collaborator
There was a problem hiding this comment.
ACK 3b6b3ba
I did rebase and update the description.
1 task
oleonardolima
added a commit
that referenced
this pull request
Jun 17, 2026
81335d8 fix(esplora): deduplicate missing txids in fetch_txs_with_outpoints (phrwlk) Pull request description: ### Description It's a backport for the the `bdk_esplora` fix introduced by #2104. If you're interested in the original fix, check the original PR for discussion/rationale. ### Changelog notice ``` ### Changed - Use `HashSet` instead of `Vec` to track `missing_txs` in bdk_esplora, it deduplicates txids. ``` ### Checklists #### All Submissions: * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) ACKs for top commit: oleonardolima: self-ACK 81335d8 luisschwab: ACK 81335d8 Tree-SHA512: 9d2ad6f97550fdbb3fb0a455b0f2fb2866023fa368dc67241b1b1493125de8cc70863014c2700770555294f8933f8524fa6ad9a243ddeb0395052d7491ef1c3a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously
fetch_txs_with_outpointscollected spend txids into a Vec, so the same txid could be pushed multiple times when one transaction spent several input outpoints. This caused redundantget_tx_infocalls to Esplora for the same transaction, wasting network and CPU without changing the resultingTxUpdate.Use
HashSet<Txid>formissing_txsin both async and blockingfetch_txs_with_outpoints,so each txid is only requested once while keeping the observable behaviour ofSyncResponse/TxUpdateunchanged.Changelog notice
Checklists
All Submissions:
New Features:
Bugfixes: