[wallet] Verify unconfirmed transactions after syncing - #355
Merged
Conversation
RCasatta
reviewed
Jun 4, 2021
afilini
marked this pull request as ready for review
June 18, 2021 11:22
afilini
force-pushed
the
feat/verify-txs
branch
2 times, most recently
from
June 18, 2021 14:04
6d77749 to
f40e673
Compare
Verify the unconfirmed transactions we download against the consensus rules. This is currently exposed as an extra `verify` feature, since it depends on a pre-release version of `bitcoinconsensus`. Closes bitcoindevkit#352
Verify the unconfirmed transactions we download against the consensus rules. This is currently exposed as an extra `verify` feature, since it depends on a pre-release version of `bitcoinconsensus`. Closes bitcoindevkit#352
RCasatta
approved these changes
Jul 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Verify the unconfirmed transactions we download against the consensus rules. This is currently exposed as an extra
verifyfeature, since it depends on a pre-release version ofbitcoinconsensus.Closes #352
Notes to the reviewers
Still missing some docs items but the code should be pretty much done
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.md