Fix derivable-descriptor detection during wallet sync - #692
Closed
evanlinjin wants to merge 1 commit into
Closed
Conversation
This fix is for electrum-based blockchains. Previously, it was assumed that containing > 1 spks in database means the descriptor is derivable, however each database tracks two descriptors so it should really check > 2.
evanlinjin
force-pushed
the
fix-non-derivable-desc-detection
branch
from
July 30, 2022 13:54
9349d3c to
9d2bea2
Compare
evanlinjin
marked this pull request as ready for review
July 30, 2022 14:02
Contributor
|
Can you add a test to reproduce the bug? I suppose that having one wallet with two non-derivable descriptors should do it |
20 tasks
Member
Author
|
@danielabrozzoni Thanks for the tip! I realized I confused myself. 😅 I forgot that I'll close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fix is for electrum-based blockchains.
Previously, it was assumed that containing > 1 spks in database means the descriptor is derivable, however each database tracks two descriptors so it should really check > 2.
Notes to the reviewers
This is a touch-up on work done in #672
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes:
* [ ] This pull request breaks the existing API* [ ] I've added tests to reproduce the issue which are now passing* [ ] I'm linking the issue being fixed by this PR