Run code coverage on every PR - #747
Merged
afilini merged 3 commits intoSep 12, 2022
Merged
Conversation
danielabrozzoni
force-pushed
the
fix/code_coverage_ci
branch
from
September 9, 2022 16:08
09d83fd to
49a20df
Compare
danielabrozzoni
changed the title
danielabrozzoni
marked this pull request as ready for review
September 9, 2022 16:09
In this way we can check how much of a PR is covered by the tests, making the review process slightly easier.
danielabrozzoni
force-pushed
the
fix/code_coverage_ci
branch
from
September 9, 2022 20:35
49a20df to
1c4d478
Compare
4 tasks
Contributor
Author
|
I had to re-push to trigger the CI, but it should be good now 👍🏻 |
danielabrozzoni
force-pushed
the
fix/code_coverage_ci
branch
from
September 10, 2022 15:49
d9c1f87 to
89e8cab
Compare
- Remove default and minimal, as they are redundant - Use lexicographic order
danielabrozzoni
force-pushed
the
fix/code_coverage_ci
branch
from
September 10, 2022 16:11
89e8cab to
aa0ea6a
Compare
notmandatory
approved these changes
Sep 11, 2022
notmandatory
left a comment
notmandatory
left a comment
Member
There was a problem hiding this comment.
ACK aa0ea6a
verified PR branch code coverage runs can be found here: https://coveralls.io/github/bitcoindevkit/bdk
afilini
approved these changes
Sep 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing