Update rust-miniscript to 9.0 - #844
Merged
notmandatory merged 1 commit intoFeb 2, 2023
Merged
Conversation
notmandatory
force-pushed
the
update_miniscript_90
branch
from
January 27, 2023 17:04
08cde33 to
cdc0dc9
Compare
notmandatory
marked this pull request as draft
January 27, 2023 17:24
Member
Author
|
I removed this PR from next release.. I first need to update |
notmandatory
force-pushed
the
update_miniscript_90
branch
from
January 31, 2023 02:03
cdc0dc9 to
a174371
Compare
Member
Author
|
All tests passing with |
Member
Author
|
The updated |
notmandatory
modified the milestones:
Release 0.28.0 Feature Freeze,
Release 0.27.0 Feature Freeze
notmandatory
force-pushed
the
update_miniscript_90
branch
from
January 31, 2023 19:54
a174371 to
ee43d20
Compare
notmandatory
force-pushed
the
update_miniscript_90
branch
from
January 31, 2023 19:55
ee43d20 to
cf8cd2f
Compare
notmandatory
marked this pull request as ready for review
January 31, 2023 19:59
Member
Author
|
This is only a dependency change so I'm not sure why coveralls is complaining that our code coverage went down. 🤷♂️ |
rajarshimaitra
approved these changes
Feb 2, 2023
rajarshimaitra
left a comment
rajarshimaitra
left a comment
Contributor
There was a problem hiding this comment.
ACK cf8cd2f
I have manually tested and all green..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A new
rust-miniscriptrelease 9.0 came out on Nov 14, updating to it to pickup the bug fixes. Also updating dependencyhwito new0.5version which used the9.0version ofrust-miniscript.Notes to the reviewers
This new version of
rust-miniscriptuses the same version ofrust-bitcoinwe are on, 0.29.1.Changelog notice
Update rust-miniscript dependency to latest bug fix release 9.0.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing