revert: "chore: deprecate wallet::signer mod" - #405
Merged
oleonardolima merged 2 commits intoMar 26, 2026
Merged
Conversation
Member
Author
|
I need to figure out why the CI job for MSRV is broken. |
Contributor
|
It can land after #415, which fixes the MSRV CI job. |
notmandatory
force-pushed
the
chore/revert_deprecated_signer
branch
from
March 25, 2026 15:33
dc0163d to
02172ea
Compare
This reverts commit 4c4e0b1.
notmandatory
force-pushed
the
chore/revert_deprecated_signer
branch
from
March 25, 2026 16:17
41239de to
77964fb
Compare
notmandatory
marked this pull request as ready for review
March 25, 2026 16:27
Member
Author
oleonardolima
changed the title
wallet::signer mod"wallet::signer mod"
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 4c4e0b1.
Will deprecate the signer mod again when the new psbt signer is ready.
Notes to the reviewers
The signer mod is not deprecated in
masterbranch and won't be until the psbt signer is ready, likely in the 3.1 release.Changelog notice
Checklists
All Submissions:
just pbefore pushing