Pre multi-keychain work (do not merge) - #523
Open
thunderbiscuit wants to merge 2 commits into
Open
Conversation
thunderbiscuit
requested review from
ValuedMammal and
oleonardolima
as code owners
August 4, 2026 19:43
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #523 +/- ##
==========================================
- Coverage 81.84% 81.79% -0.05%
==========================================
Files 25 25
Lines 6487 6362 -125
Branches 296 289 -7
==========================================
- Hits 5309 5204 -105
+ Misses 1078 1058 -20
Partials 100 100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this following the dev call discussion from August 4th.
This PR is not meant for merging. Its purpose is to separate the work on the multi-keychain feature (#227) into the parts that:
Notes to the reviewers
Take a look at this if you want. But the interesting part of the multi-keychain feature are in #524.
I will try to keep this rebased on master as well as incorporating my best understanding of what is likely to land for 4.0 if things change. If you have comments on this please let me know! I'll try to keep this PR up to date with the best expected direction.
TODO
LoadParams::descriptor->LoadParams::check_descriptor